Allows LUS to set the screen dimensions programmatically. #785
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
briaguya-ai
reviewed
Jan 7, 2025
| @@ -62,13 +62,13 @@ void Fast3dWindow::Init() { | |||
| uint32_t width, height; | |||
| int32_t posX, posY; | |||
|
|
|||
| isFullscreen = Ship::Context::GetInstance()->GetConfig()->GetBool("Window.Fullscreen.Enabled", false) || gameMode; | |||
| isFullscreen = Ship::Context::GetInstance()->GetConfig()->GetBool("Window.Fullscreen.Enabled", 0) || gameMode; | |||
There was a problem hiding this comment.
is the plan to standardize on 0 instead of false for GetBool?
briaguya-ai
reviewed
Jan 10, 2025
| posX = Ship::Context::GetInstance()->GetConfig()->GetInt("Window.PositionX", 100); | ||
| posY = Ship::Context::GetInstance()->GetConfig()->GetInt("Window.PositionY", 100); | ||
|
|
||
| if (isFullscreen) { | ||
| width = Ship::Context::GetInstance()->GetConfig()->GetInt("Window.Fullscreen.Width", gameMode ? 1280 : 1920); | ||
| height = Ship::Context::GetInstance()->GetConfig()->GetInt("Window.Fullscreen.Height", gameMode ? 800 : 1080); | ||
| width = Ship::Context::GetInstance()->GetConfig()->GetInt("Window.Fullscreen.Width", 1920); |
There was a problem hiding this comment.
need to test this in gamescope. i still don't like that we have resolution tied to gamescope, just because someone is using gamescope doesn't mean they're on a steam deck, but seeing what breaks and if we have ways around it with the other changes in this PR will be good
edit: looks like we're looking for steamdeck in the release variant id so it's not just gamescope we're checking for, but still feels a bit tacked on
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.