After patch update cache fix #794
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This won't work because the patch command is run directly in a terminal shell context. Parenthesis don't work for order of operations in shell execution. |
lightmanLP
force-pushed
the
patch-reset
branch
2 times, most recently
from
09204f6 to
874ec93
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
FetchContentupdates dependency from git, it simply keeps patched changes as unstaged ones. It is fine in case when patch is compatible with updated patch, but otherwise the build will fail until the cache is cleared from unstaged changes.Thats why I added additional check to remove unstaged changes and reapply patch, if there is a problem.