V-Sync toggle in SDL (OpenGL + Metal) #822
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
briaguya-ai
reviewed
Feb 16, 2025
src/graphic/Fast3D/gfx_sdl2.cpp
Outdated
Comment on lines
665
to
670
| if (vsync_enabled != Ship::Context::GetInstance()->GetConsoleVariables()->GetInteger(CVAR_VSYNC_ENABLED, 1)) { | ||
| // Make sure only 0 or 1 is set. | ||
| vsync_enabled = !!Ship::Context::GetInstance()->GetConsoleVariables()->GetInteger(CVAR_VSYNC_ENABLED, 1); | ||
| } | ||
| SDL_GL_SetSwapInterval(vsync_enabled); | ||
| SDL_RenderSetVSync(renderer, vsync_enabled); |
There was a problem hiding this comment.
i feel like we shouldn't be calling these every time we call SDL_GL_SwapWindow. this really should only happen when the cvar changes
There was a problem hiding this comment.
where and how would i do that?
There was a problem hiding this comment.
oh, or do you mean setting the swap interval? I thought you ment getting the cvar.
briaguya-ai
reviewed
Feb 16, 2025
src/graphic/Fast3D/gfx_sdl2.cpp
Outdated
Comment on lines
665
to
671
| if (vsync_enabled != Ship::Context::GetInstance()->GetConsoleVariables()->GetInteger(CVAR_VSYNC_ENABLED, 1)) { | ||
| // Make sure only 0 or 1 is set. | ||
| vsync_enabled = | ||
| (Ship::Context::GetInstance()->GetConsoleVariables()->GetInteger(CVAR_VSYNC_ENABLED, 1) ? 1 : 0); | ||
| SDL_GL_SetSwapInterval(vsync_enabled); | ||
| SDL_RenderSetVSync(renderer, vsync_enabled); | ||
| } |
There was a problem hiding this comment.
this does seem better than calling SDL_GL_SetSwapInterval and SDL_RenderSetVSync every time, but it'd still prefer to find a way to not need to check the cvar all the time like this
There was a problem hiding this comment.
Yeah, but I have no idea how. Any suggestion?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Works without changes on the port side, but similar changes like this are recommended: HarbourMasters/Shipwright#5074 (This can also be used as Test-PR)