Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI needs further fixing #1552

Closed
tvami opened this issue Jan 31, 2025 · 3 comments · Fixed by #1554
Closed

CI needs further fixing #1552

tvami opened this issue Jan 31, 2025 · 3 comments · Fixed by #1554
Assignees
Labels
github_actions Pull requests that update GitHub Actions code

Comments

@tvami
Copy link
Member

tvami commented Jan 31, 2025

Describe the bug

The env variable is deduced to be

  LDMX_VERSION_FILE=/home/runner/work/ldmx-sw/ldmx-sw/VERSION

or

  cat: /home/runner/work/ldmx-sw/ldmx-sw/VERSION: No such file or directory
  Traceback (most recent call last):
    File "/home/runner/work/ldmx-sw/ldmx-sw/./.github/actions/validate/compare.py", line 195, in <module>
      compare(sys.argv[1], sys.argv[2], sys.argv[3], sys.argv[4])
  IndexError: list index out of range

in https://github.com/LDMX-Software/ldmx-sw/actions/runs/13064853937/job/36455888351?pr=1551

To Reproduce

For example see
https://github.com/LDMX-Software/ldmx-sw/actions/runs/13061170684/job/36445294614

Desired behavior

Move it one directory up

@tvami tvami self-assigned this Jan 31, 2025
@tvami tvami added the github_actions Pull requests that update GitHub Actions code label Jan 31, 2025
@tvami tvami linked a pull request Jan 31, 2025 that will close this issue
2 tasks
@tvami
Copy link
Member Author

tvami commented Jan 31, 2025

Maybe the issue is that GITHUB_WORKSPACE changes for the different CIs

@tvami
Copy link
Member Author

tvami commented Jan 31, 2025

Thinking more, I think this will break the gold generation CI, otherwise this
https://github.com/LDMX-Software/ldmx-sw/pull/1550/files
would have failed

@tomeichlersmith
Copy link
Member

The problem is not with the placement of VERSION, the problem is how we distribute the gold to the various validation jobs.

We copy the gold over from trunk, but then only tar-ball up the install and the .github directory. We need to include VERSION in the tar that is then shipped to the other jobs.

- name: Git Gold Histograms from trunk
run: git checkout origin/trunk -- .github/validation_samples/*/gold.root VERSION
shell: bash
- name: Package ldmx-sw Into Artifact
run: tar cf ldmx-sw-package.tar install/ .github/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
github_actions Pull requests that update GitHub Actions code
Projects
None yet
2 participants