Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update LDMX_VERSION_FILE variable #1553

Closed
wants to merge 7 commits into from
Closed

Update LDMX_VERSION_FILE variable #1553

wants to merge 7 commits into from

Conversation

tvami
Copy link
Member

@tvami tvami commented Jan 31, 2025

I am updating ldmx-sw, here are the details.

What are the issues that this addresses?

Resolves #1552

Check List

  • I successfully compiled ldmx-sw with my developments
  • I ran my developments and the following shows that they are successful.

@tvami tvami linked an issue Jan 31, 2025 that may be closed by this pull request
CI needs further fixing #1552
Closed
@tvami tvami requested a review from tomeichlersmith January 31, 2025 01:22
@tvami tvami marked this pull request as draft January 31, 2025 03:34
@tvami tvami marked this pull request as ready for review January 31, 2025 03:40
@tvami tvami marked this pull request as draft January 31, 2025 04:20
@tvami tvami marked this pull request as ready for review January 31, 2025 04:20
@tvami tvami marked this pull request as draft January 31, 2025 05:05
@tvami tvami marked this pull request as ready for review January 31, 2025 05:05
@tvami tvami marked this pull request as draft January 31, 2025 05:41
@tvami tvami marked this pull request as ready for review January 31, 2025 05:41
@tvami
Copy link
Member Author

tvami commented Jan 31, 2025 

cat: /home/runner/work/ldmx-sw/ldmx-sw/./.github/actions/validate/../../../../../VERSION: No such file or directory

but also

cat: /home/runner/work/ldmx-sw/ldmx-sw/./.github/actions/validate/../../../../VERSION: No such file or directory

I'm giving up for tonight...

@tvami
Copy link
Member Author

tvami commented Jan 31, 2025

Closing in favor of #1554

@tvami tvami closed this Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomeichlersmith tomeichlersmith Awaiting requested review from tomeichlersmith

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CI needs further fixing
1 participant
@tvami