include VERSION in ldmx-sw package for PR validation #1554
Merged
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the VERSION file is shipped with the gold that it originates from so that we can deduce a label for the reference histograms in the plots.
|
Yea, the PR Validation is failing but it is completing the run. I don't know why the version in the run header is not up to date, but that could be because I didn't base it off the right branch? 164745,164746c164745,164746
< ldmx-sw revision = 363d575d79975040fdc30aa9c4bfc4828bbb07ce
< ldmx-sw version = v4.2.7
---
> ldmx-sw revision = 15f9e7abc9840ae[25](https://github.com/LDMX-Software/ldmx-sw/actions/runs/13074097199/job/36483066680?pr=1554#step:6:28)461467274a953e671a52ee8
> ldmx-sw version = 4.2.8 |
|
Yes, I think this is not an issue for merging this |
tvami
approved these changes
Jan 31, 2025
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the VERSION file is shipped with the gold that it originates from so that we can deduce a label for the reference histograms in the plots.
I am updating ldmx-sw, here are the details.
What are the issues that this addresses?
This resolves #1552
Check List