Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: resolve failings #8

Merged
merged 6 commits into from
Feb 19, 2024
Merged

ci: resolve failings #8

merged 6 commits into from
Feb 19, 2024

Conversation

Borda
Copy link
Member

@Borda Borda commented Feb 19, 2024

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

What does this PR do?

Fixes # (issue).

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in GitHub issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@Borda Borda added the bug Something isn't working label Feb 19, 2024
@Borda Borda requested a review from tchaton February 19, 2024 13:02
@Borda
Copy link
Member Author

Borda commented Feb 19, 2024

waiting on Lightning-AI/utilities#228

@Borda Borda marked this pull request as ready for review February 19, 2024 13:50
@Borda Borda merged commit 81edf3d into main Feb 19, 2024
28 of 29 checks passed
@Borda Borda deleted the ci/pass branch February 19, 2024 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant