Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: resolve failings #8

Merged
merged 6 commits into from
Feb 19, 2024
Merged

ci: resolve failings #8

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
d7dbee4
ci: resolve failings
Borda Feb 19, 2024
db6ee21
version
Borda Feb 19, 2024
21fecad
init
Borda Feb 19, 2024
7ca7086
use ci/mypy-dir
Borda Feb 19, 2024
a0c1f62
mypy
Borda Feb 19, 2024
81dbb00
Apply suggestions from code review
Borda Feb 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions .github/workflows/ci-checks.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,11 @@ jobs:
uses: Lightning-AI/utilities/.github/workflows/[email protected]

check-typing:
uses: Lightning-AI/utilities/.github/workflows/[email protected]
# FIXME: switch to main after fix lends
Borda marked this conversation as resolved.
Show resolved Hide resolved
uses: Lightning-AI/utilities/.github/workflows/check-typing.yml@ci/mypy-dir
with:
actions-ref: v0.10.1
actions-ref: ci/mypy-dir
source-dir: ""

check-schema:
uses: Lightning-AI/utilities/.github/workflows/[email protected]
Expand Down
3 changes: 1 addition & 2 deletions lightning_data/__about__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@

import time

__version__ = "0.2.0.dev"
__author__ = "Lightning AI et al."
__author_email__ = "[email protected]"
__license__ = "Apache-2.0"
Expand All @@ -39,5 +40,3 @@
"__license__",
"__version__",
]

__version__ = "0.2.0.dev"
6 changes: 2 additions & 4 deletions lightning_data/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,22 +1,20 @@
from lightning_utilities.core.imports import RequirementCache

from lightning_data.__about__ import * # noqa: F403
from lightning_data.processing.functions import map, optimize, walk
from lightning_data.streaming.combined import CombinedStreamingDataset
from lightning_data.streaming.dataloader import StreamingDataLoader
from lightning_data.streaming.dataset import StreamingDataset

__all__ = [
"LightningDataset",
"StreamingDataset",
"CombinedStreamingDataset",
"StreamingDataLoader",
"LightningIterableDataset",
"map",
"optimize",
"walk",
]

if RequirementCache("lightning_sdk"):
from lightning_sdk import Machine # noqa: F401

__all__.append("Machine")
__all__ + ["Machine"]
2 changes: 1 addition & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,7 @@ max-complexity = 10

[tool.mypy]
files = [
"src/lightning",
"lightning_data",
]
# This section is for folders with "-" as they are not valid python modules
exclude = [
Expand Down
3 changes: 3 additions & 0 deletions requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,11 @@ lightning-utilities >=0.8.0, <0.10.0
lightning-cloud == 0.5.64 # Must be pinned to ensure compatibility
# to be able to include also PL 2.0 and preserve `>` needed for CI min version bypass
torch >=2.1.0, <=2.2.0
lightning >=2.2.0
filelock
tqdm
numpy
torchvision
pillow
viztracer
pyarrow
5 changes: 0 additions & 5 deletions requirements/test.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,4 @@ pytest-cov ==4.1.0
pytest-timeout ==2.1.0
pytest-rerunfailures ==12.0
pytest-random-order ==1.1.0
viztracer
pandas
pyarrow
pillow
lightning
mypy
Loading