-
Notifications
You must be signed in to change notification settings - Fork 416
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: cache reference metrics & clean audio tests #2335
Conversation
it seems that hashing is not supported by its nature for |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2335 +/- ##
=======================================
- Coverage 69% 68% -1%
=======================================
Files 307 307
Lines 17352 17352
=======================================
- Hits 11961 11821 -140
- Misses 5391 5531 +140 |
@Borda, please note you can easily work around this using custom hashing logic, which |
@shaypal5, yes, I saw it but this I believe is quite often the case so it would be beneficial to cover it out of the box (I mean |
Cool. As long as you are aware this shouldn't block your use case, I'd love to get contributions by you into |
An idea bout increasing the testing range, we could move importing the dependency package to the |
* cache reference metrics * audio * classif * regress * image * others * cleaning --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> (cherry picked from commit c53ea94)
* cache reference metrics * audio * classif * regress * image * others * cleaning --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> (cherry picked from commit c53ea94)
What does this PR do?
Resolves #949
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃
📚 Documentation preview 📚: https://torchmetrics--2335.org.readthedocs.build/en/2335/