SP-534 프로필 섹션 컴포넌트 구현 #193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hyosin-Jang
reviewed
May 14, 2024
There was a problem hiding this comment.
@abiriadev
코드가 정말 깔끔하게 작성되어 있고 불필요한 부분이 없어서 읽기 쉬웠습니다!
작은 부분까지 신경쓰신 부분 멋지십니다.
저희가 컴포넌트마다 wrapper 요소의 이름을 Box, Container, ~Wrapper 등으로 다르게 짓고 있는데 혹시 하나로 통일해보는 건 어떨까요?
아래는 네이밍 예시 링크입니다!
https://usgnuscodenote.tistory.com/entry/Styled-components-Naming-Convention-%EC%9D%B4%EB%A6%84-%EA%B7%9C%EC%B9%99
SungHyun627
approved these changes
May 14, 2024
SungHyun627
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #192💡 다음 이슈를 해결했어요.
💡 필요한 후속작업이 있어요.
✅ 셀프 체크리스트