Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/labelspaces #30

Merged
merged 10 commits into from
Feb 14, 2025
Merged

Feature/labelspaces #30

merged 10 commits into from
Feb 14, 2025

Conversation

nathanhhughes
Copy link
Collaborator

Updates the metadata API slightly and formalizes the API around a labelspace to avoid json forcing the weird string keys for integer labels. Mostly just staging this for when feature/flexible_layer actually gets merged. @Schmluk mostly adding you in case you're interested but anticipate @GoldenZephyr actually doing the review

@nathanhhughes nathanhhughes force-pushed the feature/flexible_layer branch from 483fecf to f06ad91 Compare January 22, 2025 16:07
Base automatically changed from feature/flexible_layer to develop February 13, 2025 21:21
Copy link
Contributor

@GoldenZephyr GoldenZephyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I like the labelspace interface!

@nathanhhughes nathanhhughes merged commit 83b1d9d into develop Feb 14, 2025
4 checks passed
@nathanhhughes nathanhhughes deleted the feature/labelspaces branch February 14, 2025 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants