Change default for weatherEndpoint according to API 3.0

[HeikoGr]

since API 3.0 is default, weatherEndpoint should be set to "/onecall"
Fixes #3574

ATTENTION: since lat / lon defaults to 0 / 0, the weather plugins works after this patch, but shows the weather from https://de.wikipedia.org/wiki/Null_Island if lat / lon is not manually set.

[sdetweil]

as weather is all in browser we could log a message there about default lat/lon

[khassel]

@HeikoGr the tests are failing because the / before onecall, must be weatherEndpoint: "onecall",

I fixed the merge conflicts in changelog so you should fetch your master locally before working on this ... (can do that too if you want)

[sdetweil]

funny, on the module side its "/onecall"

[khassel]

funny, on the module side its "/onecall"

upsi, I tested this without and test works

as weather is all in browser we could log a message there about default lat/lon

we should think about more changes, e.g.

• removing openweathermap as default provider (leave empty or choose another)
• update code so weatherEndpoint works with and without leading slash
• ...

[khassel]

will fail again, now e2e tests, will check why ...

[HeikoGr]

ok, i will wait for your response

[khassel]

question: is onecall the new default for all weather types, for current weather, for hourly weather and for forecast?

[sdetweil]

openweather says /onecall is only

[HeikoGr]

Except for pro customers. This is why i didn‘t remove the other endpoint functions

[sdetweil]

but our users are mostly not pro. so does onecall
pull back everything and you can sort it out

[khassel]

so now I know what is happening. First thing /onecall is correct (with /).

Problem is, that if no weatherEndpoint is specified we have this function in the code:

	/**
	 * Overrides method for setting config to check if endpoint is correct for hourly
	 * @param {object} config The configuration object
	 */
	setConfig (config) {
		this.config = config;
		if (!this.config.weatherEndpoint) {
			switch (this.config.type) {
				case "hourly":
					this.config.weatherEndpoint = "/onecall";
					break;
				case "daily":
				case "forecast":
					this.config.weatherEndpoint = "/forecast";
					break;
				case "current":
					this.config.weatherEndpoint = "/weather";
					break;
				default:
					Log.error("weatherEndpoint not configured and could not resolve it based on type");
			}
		}
	},

So with a new default "/onecall" instead of "" some tests fail because their configs have no weatherEndpoint and no weatherProvider and the above function is not called anymore.

To discuss:

• all weather tests and (mock data?) are based on provider openweathermap. Is this correct @rejas ?
• if the tests are bound to the above provider we should update their configs with weatherEndpoint and weatherProvider
• do we need the function setConfig if we set a default weatherEndpoint? I think not, pro users can still set weatherEndpoint in the config

[sdetweil]

we should test without the endpoint set too
should not be required

pick a provider, it should work

[rejas]

all weather tests and (mock data?) are based on provider openweathermap. Is this correct @rejas ?

correct, we only test against openweathermap, so the mock data is specific to that provider too.

[khassel]

@HeikoGr I have a fix for the tests now, is it o.k. to push this on your branch?

[HeikoGr]

absolutely