Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change default for weatherEndpoint according to API 3.0 #3583

Merged
merged 8 commits into from
Oct 11, 2024
Merged

Change default for weatherEndpoint according to API 3.0 #3583

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
ac9da42
change default for weatherEndpoint according to API 3.0
HeikoGr Oct 9, 2024
e859271
Update CHANGELOG.md
HeikoGr Oct 9, 2024
f8060b7
Merge branch 'develop' into master
khassel Oct 9, 2024
dda63cd
Update openweathermap.js
HeikoGr Oct 9, 2024
4aba437
Update modules/default/weather/providers/openweathermap.js
HeikoGr Oct 10, 2024
0d2afe3
Update openweathermap.js
HeikoGr Oct 10, 2024
2902a3b
Update openweathermap.js
HeikoGr Oct 10, 2024
45f04bc
remove setConfig in openweathermap.js, add weatherProvider and weathe…
khassel Oct 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ _This release is scheduled to be released on 2025-01-01._

- [updatenotification] Fix pm2 using detection when pm2 script is in MagicMirror root folder (#3576)
- [core] Fix loading node_helper of modules: avoid black screen, display errors and continue loading with next module (#3578)
- [weather] changed default value for weatherEndpoint of provider openweathermap to "/onecall" (#3574)

## [2.29.0] - 2024-10-01

Expand Down
7 changes: 5 additions & 2 deletions modules/default/weather/providers/openweathermap.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,10 +17,13 @@ WeatherProvider.register("openweathermap", {
defaults: {
apiVersion: "3.0",
apiBase: "https://api.openweathermap.org/data/",
weatherEndpoint: "", // can be "onecall", "forecast" or "weather" (for current)
// weatherEndpoint is "onecall" since API 3.0
// "onecall", "forecast" or "weather" only for pro customers
weatherEndpoint: "onecall",
HeikoGr marked this conversation as resolved.
Show resolved Hide resolved
locationID: false,
location: false,
lat: 0, // the onecall endpoint needs lat / lon values, it doesn't support the locationId
// the onecall endpoint needs lat / lon values, it doesn't support the locationId
lat: 0,
lon: 0,
apiKey: ""
},
Expand Down
Loading