Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: pre compute the action to do for each change of the stack #510

Merged
merged 1 commit into from
Oct 24, 2024
Merged

refactor: pre compute the action to do for each change of the stack #510

merged 1 commit into from
Oct 24, 2024

Conversation

sileht
Copy link
Member

@sileht sileht commented Oct 23, 2024 •
edited
Loading

This will help to do/display the same thing in the dry-run and the
effective run.

@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 23, 2024 •
edited
Loading

Merge Protections

Your pull request matches the following merge protections and will not be merged until they are valid.

Changelog requirements

  • any of:
    • -title ~= ^feat
    • label = need changelog
    • label = skip changelog

Enforce conventional commit

Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/

  • title ~= ^(fix|feat|docs|style|refactor|perf|test|build|ci|chore|revert)(?:\(.+\))?:

🔎 Reviews

  • #changes-requested-reviews-by = 0
  • #review-requested = 0
  • #review-threads-unresolved = 0

@sileht sileht force-pushed the devs/sileht/merged-handling/Id57cf9a1af904636b84fe49940a7202ee70b7b84 branch 2 times, most recently from 89f8f03 to f2f1a6b Compare October 23, 2024 13:41
This was referenced Oct 23, 2024
Merged
Merged
Merged
@sileht
Copy link
Member Author

sileht commented Oct 23, 2024 •
edited
Loading

This pull request is part of a stack:

  1. refactor: pre compute the action to do for each change of the stack (#510) 👈
  2. refactor: check API response globally (#511)
  3. chore: use a more reliable solution to get changes (#512)
  4. feat: allow to pass author (#520)

@sileht sileht mentioned this pull request Oct 23, 2024
Merged
@mergify mergify bot requested a review from a team October 23, 2024 13:42
@sileht sileht force-pushed the devs/sileht/merged-handling/Ibf5631e64801175067dcc9eadd7efdb18b53645f branch from 06999ac to 2810d0c Compare October 23, 2024 13:47
@sileht sileht changed the title chore: pre compute the action to do for each change of the stack refactor: pre compute the action to do for each change of the stack Oct 23, 2024
@sileht sileht force-pushed the devs/sileht/merged-handling/Id57cf9a1af904636b84fe49940a7202ee70b7b84 branch from f2f1a6b to 929018b Compare October 23, 2024 13:48
@sileht sileht force-pushed the devs/sileht/merged-handling/Ibf5631e64801175067dcc9eadd7efdb18b53645f branch from 2810d0c to f20cc90 Compare October 23, 2024 18:49
@sileht sileht force-pushed the devs/sileht/merged-handling/Id57cf9a1af904636b84fe49940a7202ee70b7b84 branch from 929018b to f33eaf3 Compare October 23, 2024 18:49
This was referenced Oct 23, 2024
Merged
Merged
Closed
Closed
Closed
@sileht sileht force-pushed the devs/sileht/merged-handling/Id57cf9a1af904636b84fe49940a7202ee70b7b84 branch from f33eaf3 to 6aed1a9 Compare October 23, 2024 18:59
jd
jd previously requested changes Oct 24, 2024
View reviewed changes
mergify_cli/__init__.py Outdated Show resolved Hide resolved
@sileht sileht force-pushed the devs/sileht/merged-handling/Ibf5631e64801175067dcc9eadd7efdb18b53645f branch from f20cc90 to 16f9737 Compare October 24, 2024 09:07
@sileht sileht force-pushed the devs/sileht/merged-handling/Id57cf9a1af904636b84fe49940a7202ee70b7b84 branch from 6aed1a9 to 54f8af6 Compare October 24, 2024 09:07
@sileht sileht mentioned this pull request Oct 24, 2024
Merged
@mergify mergify bot dismissed jd’s stale review October 24, 2024 09:08

Pull request has been modified.

@mergify mergify bot requested a review from a team October 24, 2024 09:08
Base automatically changed from devs/sileht/merged-handling/Ibf5631e64801175067dcc9eadd7efdb18b53645f to main October 24, 2024 09:27
@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 24, 2024

@sileht this pull request is now in conflict 😩

@mergify mergify bot added the conflict label Oct 24, 2024
@sileht
refactor: pre compute the action to do for each change of the stack
04d5669 
This will help to do/display the same thing in the dry-run and the
effective run.

Change-Id: Id57cf9a1af904636b84fe49940a7202ee70b7b84
@sileht sileht force-pushed the devs/sileht/merged-handling/Id57cf9a1af904636b84fe49940a7202ee70b7b84 branch from 54f8af6 to 04d5669 Compare October 24, 2024 10:54
@mergify mergify bot removed the conflict label Oct 24, 2024
@mergify mergify bot merged commit e2b6588 into main Oct 24, 2024
5 checks passed
@mergify mergify bot added the queued label Oct 24, 2024
@mergify mergify bot deleted the devs/sileht/merged-handling/Id57cf9a1af904636b84fe49940a7202ee70b7b84 branch October 24, 2024 15:55
@mergify mergify bot removed the queued label Oct 24, 2024
@sileht sileht mentioned this pull request Oct 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Syffe Syffe Syffe approved these changes

@jd jd jd left review comments

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sileht @jd @Syffe