Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: check API response globally #511

Merged
merged 1 commit into from
Oct 29, 2024
Merged

refactor: check API response globally #511

merged 1 commit into from
Oct 29, 2024

Conversation

sileht
Copy link
Member

@sileht sileht commented Oct 23, 2024 •
edited
Loading

No description provided.

This was referenced Oct 23, 2024
Merged
Merged
Merged
Merged
@sileht
Copy link
Member Author

sileht commented Oct 23, 2024 •
edited
Loading

This pull request is part of a stack:

  1. refactor: check API response globally (#511) 👈
  2. chore: use a more reliable solution to get changes (#512)
  3. feat: allow to pass author (#520)
  4. fix: handle correctly when body is empty (#529)
  5. feat: add stack checkout (#523)
  6. feat: add stack github-action-auto-rebase command (#527)

This was referenced Oct 23, 2024
Merged
Closed
Closed
@mergify mergify bot requested a review from a team October 23, 2024 18:50
@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 23, 2024 •
edited
Loading

Merge Protections

Your pull request matches the following merge protections and will not be merged until they are valid.

Changelog requirements

  • any of:
    • -title ~= ^feat
    • label = need changelog
    • label = skip changelog

Enforce conventional commit

Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/

  • title ~= ^(fix|feat|docs|style|refactor|perf|test|build|ci|chore|revert)(?:\(.+\))?:

🔎 Reviews

  • #changes-requested-reviews-by = 0
  • #review-requested = 0
  • #review-threads-unresolved = 0

@sileht sileht mentioned this pull request Oct 23, 2024
Closed
@sileht sileht force-pushed the devs/sileht/merged-handling/Id57cf9a1af904636b84fe49940a7202ee70b7b84 branch from f33eaf3 to 6aed1a9 Compare October 23, 2024 18:59
@sileht sileht force-pushed the devs/sileht/merged-handling/I79aa6f8ebb983924a004f9942d2abfab1d8c27a9 branch from f115504 to e1d9ace Compare October 23, 2024 18:59
jd
jd previously approved these changes Oct 24, 2024
View reviewed changes
@sileht sileht force-pushed the devs/sileht/merged-handling/Id57cf9a1af904636b84fe49940a7202ee70b7b84 branch from 6aed1a9 to 54f8af6 Compare October 24, 2024 09:07
@sileht sileht force-pushed the devs/sileht/merged-handling/I79aa6f8ebb983924a004f9942d2abfab1d8c27a9 branch from e1d9ace to 4ecd332 Compare October 24, 2024 09:07
@sileht sileht mentioned this pull request Oct 24, 2024
Merged
@mergify mergify bot dismissed jd’s stale review October 24, 2024 09:08

Pull request has been modified.

@mergify mergify bot requested a review from a team October 24, 2024 09:09
@sileht sileht force-pushed the devs/sileht/merged-handling/Id57cf9a1af904636b84fe49940a7202ee70b7b84 branch from 54f8af6 to 04d5669 Compare October 24, 2024 10:54
@sileht sileht force-pushed the devs/sileht/merged-handling/I79aa6f8ebb983924a004f9942d2abfab1d8c27a9 branch from 4ecd332 to 3bbf4f1 Compare October 24, 2024 10:54
Base automatically changed from devs/sileht/merged-handling/Id57cf9a1af904636b84fe49940a7202ee70b7b84 to main October 24, 2024 15:55
@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 24, 2024

@sileht this pull request is now in conflict 😩

@mergify mergify bot added the conflict label Oct 24, 2024
@sileht sileht mentioned this pull request Oct 24, 2024
Merged
@sileht sileht force-pushed the devs/sileht/merged-handling/I79aa6f8ebb983924a004f9942d2abfab1d8c27a9 branch from 3bbf4f1 to 15edf23 Compare October 25, 2024 09:00
@mergify mergify bot removed the conflict label Oct 25, 2024
This was referenced Oct 25, 2024
Closed
Merged
Closed
jd
jd previously approved these changes Oct 25, 2024
View reviewed changes
@sileht sileht mentioned this pull request Oct 25, 2024
Merged
@sileht
refactor: check API response globally
e30aa5e 
Change-Id: I79aa6f8ebb983924a004f9942d2abfab1d8c27a9
@sileht sileht force-pushed the devs/sileht/merged-handling/I79aa6f8ebb983924a004f9942d2abfab1d8c27a9 branch from 15edf23 to e30aa5e Compare October 28, 2024 13:37
@mergify mergify bot dismissed jd’s stale review October 28, 2024 13:37

Pull request has been modified.

@mergify mergify bot requested a review from a team October 28, 2024 13:38
@mergify mergify bot merged commit f2a95ea into main Oct 29, 2024
5 checks passed
@mergify mergify bot added the queued label Oct 29, 2024
@mergify mergify bot deleted the devs/sileht/merged-handling/I79aa6f8ebb983924a004f9942d2abfab1d8c27a9 branch October 29, 2024 08:20
@mergify mergify bot removed the queued label Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Greesb Greesb Greesb approved these changes

@jd jd jd left review comments

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sileht @jd @Greesb