Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #1574 #1575

Merged
merged 9 commits into from
Nov 17, 2023
Merged

Fixes #1574 #1575

merged 9 commits into from
Nov 17, 2023

Conversation

sjanzou
Copy link
Collaborator

@sjanzou sjanzou commented Nov 15, 2023

Goes with NREL/ssc#1089

@brtietz
Copy link
Collaborator

brtietz commented Nov 15, 2023

Looks like this is failing due to "No default value found for 'batt_dispatch_auto_can_fuelcellcharge' in external file (PVWatts Wind Battery Hybrid/Single Owner), using internal default" (this may affect more than just this hybrid)

@brtietz
Copy link
Collaborator

brtietz commented Nov 15, 2023

A second callback error in this configuration:

Could not evaluate callback function:Battery Dispatch Automated FOM->on_load
[6]: reference to unassigned variable:show_hide_charge_options
[6]: error: _s
[5]: eval error in statement list

@mjprilliman
Copy link
Collaborator

Looks like this is failing due to "No default value found for 'batt_dispatch_auto_can_fuelcellcharge' in external file (PVWatts Wind Battery Hybrid/Single Owner), using internal default" (this may affect more than just this hybrid)

I was working on adding these checkboxes in another branch (#1566), I can merge that into this branch once done.

@sjanzou
Copy link
Collaborator Author

sjanzou commented Nov 16, 2023

@mjprilliman , the startup dependent vartable was set to fuel cell vartable (2) instead of the battery vartable (3) for the PVWatts-Wind-FuelCell-Battery / Single Owner configuration... please update in your branch as follows:
image

Copy link
Collaborator

@brtietz brtietz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!

@brtietz brtietz merged commit 638110f into develop Nov 17, 2023
4 checks passed
@brtietz
Copy link
Collaborator

brtietz commented Nov 17, 2023 via email

@sjanzou sjanzou deleted the SAM_1574 branch November 19, 2023 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FOM battery automated dispatch broken for hybrids
3 participants