This repository has been archived by the owner on Oct 18, 2024. It is now read-only.
Add support for custom events fired by clicking on notifications. #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://nativephp.com/docs/1/the-basics/notifications#notification-click-events says that you can send custom events when clicking on a notification. However, this code currently always sends the same static event, and furthermore can be improved by sending the payload of the click event for better handling of the click event in PHP. This code will also benefit from a related PR to nativephp/laravel.
gabrieljmj
reviewed
Jul 27, 2023
| @@ -4,14 +4,15 @@ import {notifyLaravel} from "../utils"; | |||
| const router = express.Router(); | |||
|
|
|||
| router.post('/', (req, res) => { | |||
| const {title, body} = req.body | |||
| const {title, body, customEvent: event} = req.body | |||
There was a problem hiding this comment.
Suggested change
| const {title, body, customEvent: event} = req.body | |
| const {title, body, event: customEvent} = req.body |
There was a problem hiding this comment.
Did you mean to also submit suggestions for line 8? And I'm not actually sure what the response from the API is for retrieving the event name provided when registering a notification.
|
@LukeTowers I'm not sure where you're up to with this PR, but I'm going to close it as this repo is moving into the main If you decide to pick this back up, please feel free to PR on that repo instead. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://nativephp.com/docs/1/the-basics/notifications#notification-click-events says that you can send custom events when clicking on a notification. However, this code currently always sends the same static event, and furthermore can be improved by sending the payload of the click event for better handling of the click event in PHP.
This code will also benefit from a related PR to nativephp/laravel.