Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate Plugin #109

Merged
merged 5 commits into from
Oct 18, 2024
Merged

Integrate Plugin #109

merged 5 commits into from
Oct 18, 2024

Conversation

RobertWesner
Copy link
Contributor

Implemented the subpath import suggestion.

Relates to #108

Both native:serve and native:build linux x64 worked.

@RobertWesner
Copy link
Contributor Author

The electron-plugin tests give following error:

TypeError: electron_store_1.default is not a constructor

As far as I could reproduce this error existed in the electron-plugin repository before it was integrated. For now they will stay broken since the scope of this pull request is the integration via subpath import, not fixing existing tests.

@RobertWesner RobertWesner marked this pull request as ready for review October 5, 2024 15:27
Copy link
Member

@simonhamp simonhamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I have to say I prefer this approach over having to do the gymnastics we were trying in #108

What do you think @gwleuverink?

@gwleuverink
Copy link
Contributor

Incredible work! This is a way nicer solution 🙌

I like that the plugin build step can be run from the project root too

@RobertWesner
Copy link
Contributor Author

Thank you both for the kind words! This should work on all platforms but it would probably be wise to test on other systems. As I don't have a macOS device at the moment, I'd appreciate someone confirming this working outside of Linux.

@simonhamp
Copy link
Member

IT WORKS!

@simonhamp simonhamp merged commit d262ae9 into NativePHP:main Oct 18, 2024
6 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants