-
-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate Plugin #109
Integrate Plugin #109
Conversation
The electron-plugin tests give following error:
As far as I could reproduce this error existed in the electron-plugin repository before it was integrated. For now they will stay broken since the scope of this pull request is the integration via subpath import, not fixing existing tests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! I have to say I prefer this approach over having to do the gymnastics we were trying in #108
What do you think @gwleuverink?
Incredible work! This is a way nicer solution 🙌 I like that the plugin build step can be run from the project root too |
Thank you both for the kind words! This should work on all platforms but it would probably be wise to test on other systems. As I don't have a macOS device at the moment, I'd appreciate someone confirming this working outside of Linux. |
IT WORKS! |
Implemented the subpath import suggestion.
Relates to #108
Both
native:serve
andnative:build linux x64
worked.