valhalla: 3.4.0 -> 3.5.1 #375449
Merged
valhalla: 3.4.0 -> 3.5.1 #375449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Running nixpkgs-review right now and I already see |
|
You can move libspatialite changes to separate PR to get it merged sooner. |
|
I'm not in a hurry. |
GaetanLepage
reviewed
Feb 2, 2025
|
Does osmscout-server work with valhalla 3.5.1? There's no valhalla.json-3.5.1 here: https://github.com/rinigus/osmscout-server/tree/master/data, so it probably won't work (There are no unit-tests, so you'd need to run osmscout-server manually and test it with e.g. pure-maps to see if routing still works correctly). Since osmscout-server is currently the only package in nixpkgs that depends on valhalla, either we need to keep a copy of valhalla 3.4 around for osmscout-server to use, or we need to wait until osmscout-server is able to use valhalla 3.5 before updating the main valhalla package. |
Merged :) |
|
In testing #375451, I see valhalla is also broken in a similar-but-different way. I assume the easiest way to fix valhalla is to update it to 3.5.1? In which case, we presumably have two options to get osmscout-server building and working:
If it was just the valhalla update that was breaking osmscout-server, I would probably go with option 1 to start with. However, as osmscout-server is already broken, I don't really mind which route we take, as long as we try not to leave it buildable-but-broken for too long. |
Co-authored-by: Gaétan Lepage <[email protected]>
tobim
force-pushed
the
pkgs/valhalla-3.5.1
branch
from
3b6c0e6 to
afc3d4a
Compare
That was at least the first thing I tried and it worked. It is also the reason I'd prefer to go with your option 2 for osmscout-server. Since you already added support for 3.4.0, may I ask you to do this update? I myself don't know what would be needed for that.
Maybe you could add a post installation test to make it not buildable when broken? |
This issue is solved now. All linux builds are green in nixpkgs-unstable https://github.com/imincik/nix-utils/actions/runs/13151221904 . |
|
wegank
added
the
12.approvals: 1
|
Unfortunately, this PR is breaking spatialite_tools and possibly breaking otb as well. Also, I see many packages broken on darwin . @GaetanLepage , did you broken packages reported by your nixpkgs-review properly ? Look to me that we should consider to revert this PR |
This is unfortunate indeed. I did not assume those three failures on Linux to be regressions, my bad. |
|
Just checked on Hydra, otb was already broken before this PR, but spatialite_tools was broken by THIS PR. |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also:
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.