[16.0][port][account_invoice_inter_company] attach pdf

[bguillot]

Hello,

This is a port of #283 to add the invoice pdf in both companies

[victoralmau]

I think it would be more appropriate to make the copy() of the ir.attachment of the source invoice indicating the res_id of the destination invoice reducing and simplifying the code. What do you think?

[bguillot]

Hello, I think the pdf is not always generated in the other company, and in case of several attachments, how to know which one to take ?
It's safer to generate the right attachment.

[florian-dacosta]

LGTM
I also think it is safer to generate the report.
AFAIK, at this stage, it is probable that the pdf does not exist yet on the customer invoice.

[victoralmau]

Ping @pedrobaeza

[pedrobaeza]

Suggested change

	report = self.env.ref("account.account_invoices").with_company(self.company_id)
	report = self.env.ref("account.account_invoices").with_company(supplier_invoice.company_id)

[florian-dacosta]

I think we really want the customer invoice's pdf here (to attach it on the supplier invoice).
Why would we generate the pdf of customer invoice (which is self) using the supplier invoice's company ?
Maybe the with_company is kind of useless since the current company should already be self.company_id, but I don't understand why we would want to use the supplier one.

[pedrobaeza]

OK, right. I have mixed things, but I think this would help if self is the supplier invoice, as it's the target of the action to do (attach there the customer invoice), and it's also advised to add docstrings. Let's not block this anyway.

[pedrobaeza]

/ocabot merge patch

[OCA-git-bot]

On my way to merge this fine PR!
Prepared branch 16.0-ocabot-merge-pr-766-by-pedrobaeza-bump-patch, awaiting test results.

[pedrobaeza]

And the commit messages are horrible too...

Please next time stick to guidelines:

https://github.com/OCA/odoo-community.org/blob/master/website/Contribution/CONTRIBUTING.rst#commit-message

[OCA-git-bot]

Congratulations, your PR was merged at e91a86b. Thanks a lot for contributing to OCA. ❤️