Threshold flow/v1 #10544
Closed
Threshold flow/v1 #10544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implemented as a special "flowvar" holding the threshold entries. Ticket: OISF#6822.
victorjulien
force-pushed
the
threshold-flow/v1
branch
from
f0518cf to
681ccb7
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #10544 +/- ##
==========================================
+ Coverage 78.40% 82.65% +4.25%
==========================================
Files 922 922
Lines 246779 247031 +252
==========================================
+ Hits 193488 204188 +10700
+ Misses 53291 42843 -10448
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
Information: QA ran without warnings. Pipeline 18906 |
|
To provide some context: my idea is to update the stream events to use this to reduce stream event alerts per flow. Per flow tracking means relatively low overhead. |
|
On first look, things look OK. But I find there is some detail lacking in the ticket and/or commit message as to why. |
|
Information: QA ran without warnings. Pipeline 18920 |
Closed
|
replaced by #10550 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SV_BRANCH=OISF/suricata-verify#1677
https://redmine.openinfosecfoundation.org/issues/6822