Threshold flow/v2 #10550
Closed
Threshold flow/v2 #10550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support for 'by_flow' track option. This allows using the various
threshold options in the context of a single flow.
Example:
alert tcp ... stream-event:pkt_broken_ack; \
threshold:type limit, track by_flow, count 1, seconds 3600;
The example would limit the number of alerts to once per hour for
packets triggering the 'pkt_broken_ack' stream event.
Implemented as a special "flowvar" holding the threshold entries. This
means no synchronization is required, making this a cheaper option
compared to the other trackers.
Ticket: OISF#6822.
Allow rate_filter and thresholds from the global config to specify tracking "by_flow".
Closed
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #10550 +/- ##
==========================================
+ Coverage 78.40% 82.67% +4.27%
==========================================
Files 922 922
Lines 246779 247037 +258
==========================================
+ Hits 193488 204250 +10762
+ Misses 53291 42787 -10504
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
Information: QA ran without warnings. Pipeline 18926 |
inashivb
reviewed
Mar 4, 2024
| @@ -35,6 +35,7 @@ enum VarTypes { | |||
| VAR_TYPE_FLOW_BIT, | |||
| VAR_TYPE_FLOW_INT, | |||
| VAR_TYPE_FLOW_VAR, | |||
| VAR_TYPE_FLOW_THRESHOLD, | |||
There was a problem hiding this comment.
I was expecting VarNameStore* ops corresponding to this but I see nothing. Could you please tell why was this type added?
There was a problem hiding this comment.
Good question, I will look into it. It seems the current use of these types is a bit inconsistent.
Closed
|
replaced by #10568 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SV_BRANCH=OISF/suricata-verify#1679
https://redmine.openinfosecfoundation.org/issues/6822
replaces #10544: