-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert byte_extract parser to Rust. #10624
Conversation
Information: QA ran without warnings. Pipeline 19262 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #10624 +/- ##
==========================================
+ Coverage 82.69% 82.72% +0.03%
==========================================
Files 926 927 +1
Lines 247574 247513 -61
==========================================
+ Hits 204719 204756 +37
+ Misses 42855 42757 -98
Flags with carried forward coverage won't be shown. Click here to find out more. |
Information: QA ran without warnings. Pipeline 19332 |
Issue: 6873 Refactor the enums for endian and base handling for broader use.
Implement the keyword parser in Rust. Issue: 6831
WARNING:
Pipeline 19629 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, looks good overall, some nits though
Continued in #10706 |
Convert the byte_extract option parser from C to Rust.
Link to redmine ticket: 6873
Describe changes:
Provide values to any of the below to override the defaults.
To use a pull request use a branch name like
pr/N
whereN
is thepull request number.
Alternatively,
SV_BRANCH
may also be a link to anOISF/suricata-verify pull-request.