Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added getDelegationChainLength #725

Open
wants to merge 4 commits into
base: dev
Choose a base branch
from
Open

Added getDelegationChainLength #725

wants to merge 4 commits into from
+66 −0

Conversation

piotrwitek
Copy link
Collaborator

@piotrwitek piotrwitek commented Jan 31, 2025 •
edited by coderabbitai bot
Loading

Added getDelegationChainLength

Summary by CodeRabbit

  • New Features
    • Added a new method to retrieve the delegation chain length for a user across multiple components of the SDK.
    • Introduced functionality to query the length of a user's delegation chain through various interfaces and implementations.

@piotrwitek
Improve error handling in API requests
5eefe17 
Enhance error handling mechanisms for API requests to provide clearer feedback and improve debugging capabilities.
@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 31, 2025 •
edited
Loading

Warning

Rate limit exceeded

@piotrwitek has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 16 minutes and 56 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between bb60395 and 9dbf870.

📒 Files selected for processing (1)
  • sdk/sdk-server/src/armada-protocol-handlers/users/getDelegationChainLength.ts (1 hunks)

Walkthrough

This pull request adds the getDelegationChainLength method in several components of the Armada SDK, allowing retrieval of a user's delegation chain length. The method is implemented in interfaces, service classes, client components, and server procedures.

Changes

File Change Summary
sdk/armada-protocol-common/...IArmadaManagerGovernance.ts Added getDelegationChainLength interface method
sdk/armada-protocol-service/...ArmadaManagerGovernance.ts Implemented getDelegationChainLength method using blockchain client
sdk/sdk-client/...IArmadaManagerUsersClient.ts Added getDelegationChainLength interface method
sdk/sdk-client/...ArmadaManagerUsersClient.ts Implemented getDelegationChainLength client method
sdk/sdk-server/...SDKAppRouter.ts Imported and added getDelegationChainLength to router
sdk/sdk-server/...getDelegationChainLength.ts Created new procedure with input validation

Possibly related PRs

Suggested reviewers

  • halaprix
  • marcinciarka

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@piotrwitek piotrwitek changed the title Improve error handling in API requests Added getDelegationChainLength Jan 31, 2025
piekczyk
piekczyk previously approved these changes Jan 31, 2025
View reviewed changes
coderabbitai[bot]
coderabbitai bot reviewed Jan 31, 2025
View reviewed changes
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 4

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f27953e and 5eefe17.

📒 Files selected for processing (6)
  • sdk/armada-protocol-common/src/common/interfaces/IArmadaManagerGovernance.ts (1 hunks)
  • sdk/armada-protocol-service/src/common/implementation/ArmadaManagerGovernance.ts (1 hunks)
  • sdk/sdk-client/src/implementation/ArmadaManager/ArmadaManagerUsersClient.ts (1 hunks)
  • sdk/sdk-client/src/interfaces/ArmadaManager/IArmadaManagerUsersClient.ts (1 hunks)
  • sdk/sdk-server/src/SDKAppRouter.ts (2 hunks)
  • sdk/sdk-server/src/armada-protocol-handlers/users/getDelegationChainLength.ts (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (2)
  • GitHub Check: Build and Unit Test
  • GitHub Check: Build and Integration Test
🔇 Additional comments (3)
sdk/sdk-server/src/SDKAppRouter.ts (1)

56-56: LGTM!

Import and router configuration are correctly implemented.

Also applies to: 112-112

sdk/sdk-client/src/implementation/ArmadaManager/ArmadaManagerUsersClient.ts (1)

187-191: LGTM!

Implementation follows class patterns and correctly delegates to RPC client.

sdk/sdk-client/src/interfaces/ArmadaManager/IArmadaManagerUsersClient.ts (1)

336-344: LGTM!

Interface method is well documented and consistent with other methods.

sdk/sdk-server/src/armada-protocol-handlers/users/getDelegationChainLength.ts Outdated Show resolved Hide resolved
sdk/armada-protocol-common/src/common/interfaces/IArmadaManagerGovernance.ts Outdated Show resolved Hide resolved
sdk/armada-protocol-service/src/common/implementation/ArmadaManagerGovernance.ts Outdated Show resolved Hide resolved
sdk/armada-protocol-service/src/common/implementation/ArmadaManagerGovernance.ts Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Jan 31, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Please upload report for BASE (dev@b53c503). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...entation/ArmadaManager/ArmadaManagerUsersClient.ts 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@          Coverage Diff           @@
##             dev     #725   +/-   ##
======================================
  Coverage       ?   66.48%           
======================================
  Files          ?       20           
  Lines          ?      179           
  Branches       ?        4           
======================================
  Hits           ?      119           
  Misses         ?       60           
  Partials       ?        0

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

coderabbitai[bot]
coderabbitai bot reviewed Feb 5, 2025
View reviewed changes
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5eefe17 and e200d27.

📒 Files selected for processing (3)
  • sdk/armada-protocol-common/src/common/interfaces/IArmadaManagerGovernance.ts (1 hunks)
  • sdk/armada-protocol-service/src/common/implementation/ArmadaManagerGovernance.ts (1 hunks)
  • sdk/sdk-server/src/armada-protocol-handlers/users/getDelegationChainLength.ts (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (2)
  • sdk/armada-protocol-common/src/common/interfaces/IArmadaManagerGovernance.ts
  • sdk/armada-protocol-service/src/common/implementation/ArmadaManagerGovernance.ts

sdk/sdk-server/src/armada-protocol-handlers/users/getDelegationChainLength.ts Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

@piekczyk piekczyk piekczyk left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@piotrwitek @codecov-commenter @piekczyk