This repository has been archived by the owner on Oct 24, 2021. It is now read-only.
feat/better_CPS #49
Closed
feat/better_CPS #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JarbasAl
force-pushed
the
feat/better_CPS
branch
from
3b136f5 to
c8627be
Compare
Merged
JarbasAl
force-pushed
the
feat/better_CPS
branch
from
c8627be to
43e99f9
Compare
JarbasAl
force-pushed
the
feat/better_CPS
branch
from
79f66c3 to
a833c4a
Compare
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
work in progress for BetterCommonPlay framework
not yet ready, PR opened for reference only
integrates with mycroft via https://github.com/JarbasSkills/skill-better-playback-control/tree/better_cps
skills in https://github.com/JarbasSkills that have a branch named
better_cpscan be used for testingMycroft
This is based (but diverged a lot) from some PRs i had made to mycroft back in August 2020, it no longer cares about mycroft-core constraints and is now fully standalone/add-on instead of a set of changes to existing common play framework
backwards compatibility for skills is being worked on, but the official mycroft playback control skill needs to be blacklisted
For reference