Reg arbitration #199
Merged
Reg arbitration #199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you provide the performance impact of this patch here? |
tastynoob
force-pushed
the
reg-arbitration
branch
from
36540f6
to
df51ffd
Compare
|
|
|
This is performance gap, but not the impact of this patch. |
|
|
tastynoob
force-pushed
the
reg-arbitration
branch
from
df51ffd
to
77ef9f2
Compare
shinezyy
requested changes
Nov 8, 2024
src/cpu/o3/issue_queue.cc
Outdated
| #define RF_INTID 0 | ||
| #define RF_FPID 1 | ||
|
|
||
| // rftpi = regfile typeid + portid |
There was a problem hiding this comment.
tpi seems to be strange.
TyPoID? or full name: typePortID
src/cpu/o3/issue_queue.cc
Outdated
| @@ -241,7 +284,21 @@ IssueQue::retryMem(const DynInstPtr& inst) | |||
| iqstats->retryMem++; | |||
| DPRINTF(Schedule, "retry %s [sn:%llu]\n", enums::OpClassStrings[inst->opClass()], inst->seqNum); | |||
| // scheduler->loadCancel(inst); | |||
| scheduler->addToFU(inst); | |||
| // scheduler->addToFU(inst); | |||
src/cpu/o3/issue_queue.cc
Outdated
| @@ -405,6 +474,7 @@ bool | |||
| IssueQue::full() | |||
| { | |||
| bool full = instNumInsert + instNum >= iqsize; | |||
| full |= replayQ.size() > 32; // TODO: parameterize it | |||
There was a problem hiding this comment.
Maybe remove this future
src/cpu/o3/issue_queue.cc
Outdated
| { | ||
| dispTable.resize(enums::OpClass::Num_OpClass); | ||
| opExecTimeTable.resize(enums::OpClass::Num_OpClass, 1); | ||
| opPipelined.resize(enums::OpClass::Num_OpClass, false); | ||
|
|
||
| boost::dynamic_bitset<> opChecker(enums::Num_OpClass, 0); | ||
| std::vector<int> rfportChecker(64, 0); |
There was a problem hiding this comment.
The meaning of 64? add comments or replace it with constants
src/cpu/o3/issue_queue.cc
Outdated
| } | ||
| maxTPI += 1; | ||
| assert(maxTPI <= 64); |
There was a problem hiding this comment.
The meaning of 64? add comments or replace it with constants
| maxTPI = std::max(maxTPI, tpi.first); | ||
| rfportChecker[tpi.first] += 1; | ||
| } | ||
| } |
There was a problem hiding this comment.
Can we use const auto & here?
tastynoob
force-pushed
the
reg-arbitration
branch
3 times, most recently
from
3c3fe29
to
64b30e4
Compare
shinezyy
approved these changes
Nov 8, 2024
tastynoob
force-pushed
the
reg-arbitration
branch
from
64b30e4
to
061e7d3
Compare
move scheduler to one config python file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.