-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor IO tests #2111
Merged
wolfgangwalther
merged 8 commits into
PostgREST:main
from
wolfgangwalther:refactor-io-tests
Jan 4, 2022
Merged
Refactor IO tests #2111
wolfgangwalther
merged 8 commits into
PostgREST:main
from
wolfgangwalther:refactor-io-tests
Jan 4, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wolfgangwalther
commented
Jan 3, 2022
This was referenced Jan 3, 2022
Merged
wolfgangwalther
force-pushed
the
refactor-io-tests
branch
from
January 3, 2022 22:03
d64cf5d
to
85db76d
Compare
steve-chavez
approved these changes
Jan 3, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice spring cleaning 🌼 !
wolfgangwalther
force-pushed
the
refactor-io-tests
branch
from
January 4, 2022 08:11
85db76d
to
0e029a9
Compare
Local test improves performance by 15%.
Unix sockets are the default in io tests and we are testing ip connections explicitly.
wolfgangwalther
force-pushed
the
refactor-io-tests
branch
from
January 4, 2022 08:23
0e029a9
to
4821524
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While hacking on other stuff, I made a couple of improvements to our io tests. These changes:
*parallel running not working, yet, due to other problems, but getting there