Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor IO tests #2111

Merged
merged 8 commits into from
Jan 4, 2022
Merged

Conversation

wolfgangwalther
Copy link
Member

While hacking on other stuff, I made a couple of improvements to our io tests. These changes:

  • improve io test performance by ~20% on my machine
  • improve diagnostic log output when tests fail
  • improve maintainability by:
    • removing two now redundant test-cases
    • separating io test SQL fixtures from spec fixtures
  • refactor the new admin tests to not block potential parallel running* of io tests (@steve-chavez watch out - you'll need to rebase your new admin test in Consider schema cache state on the health check #2107)

*parallel running not working, yet, due to other problems, but getting there

test/io-tests/configs/unix-socket.config Show resolved Hide resolved
test/io-tests/test_io.py Show resolved Hide resolved
test/io-tests/test_io.py Show resolved Hide resolved
test/io-tests/db_config.sql Show resolved Hide resolved
test/io-tests/fixtures.sql Show resolved Hide resolved
Copy link
Member

@steve-chavez steve-chavez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice spring cleaning 🌼 !

Local test improves performance by 15%.
Unix sockets are the default in io tests and we are testing ip connections explicitly.
@wolfgangwalther wolfgangwalther merged commit cc90078 into PostgREST:main Jan 4, 2022
@wolfgangwalther wolfgangwalther deleted the refactor-io-tests branch January 5, 2022 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants