-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cherry pick non-breaking fixes for a PATCH version release #2296
Conversation
This is not allowed via personal access token right now and could be re-enabled in the future, once solved by docker hub.
8b45683
to
1ee692c
Compare
…ent of a json_agg result
Removes a bit of dead code from SpecHelper.hs
Bumps [actions/download-artifact](https://github.com/actions/download-artifact) from 2.0.10 to 2.1.0. - [Release notes](https://github.com/actions/download-artifact/releases) - [Commits](actions/download-artifact@v2.0.10...v2.1.0) --- updated-dependencies: - dependency-name: actions/download-artifact dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 2.2.4 to 2.3.0. - [Release notes](https://github.com/actions/upload-artifact/releases) - [Commits](actions/upload-artifact@v2.2.4...v2.3.0) --- updated-dependencies: - dependency-name: actions/upload-artifact dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
Also refactors defaultCorsPolicy and corsPolicy and cleans up CORS tests
Those default to "utf-8" anyway.
…read all available input
Local test improves performance by 15%.
Unix sockets are the default in io tests and we are testing ip connections explicitly.
Done by upgrading to warp 3.3.19
…the no parameter function if it exists Using GET with text/plain or application/octet-stream as Content-Type headers no longer returns 404 Not Found when a function with no parameters exists
…PostgREST#2203) * Switch to no type for json/jsonb
Bumps [actions/cache](https://github.com/actions/cache) from 2.1.7 to 3. - [Release notes](https://github.com/actions/cache/releases) - [Commits](actions/cache@v2.1.7...v3) --- updated-dependencies: - dependency-name: actions/cache dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action) from 2.1.0 to 3.0.0. - [Release notes](https://github.com/codecov/codecov-action/releases) - [Changelog](https://github.com/codecov/codecov-action/blob/master/CHANGELOG.md) - [Commits](codecov/codecov-action@v2.1.0...v3.0.0) --- updated-dependencies: - dependency-name: codecov/codecov-action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
Added many of the fixes you mentioned, but these ones may be more complicated so I excluded them:
This adds a test for the health check feature here:
It depends on d9f7f6f, which in turn looks like it depends on
It uses files created after a refactor. |
…alid syntax * Add columns for the m2m relationship
Now only builds aarch64 on the remote server without Docker
Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action) from 3.0.0 to 3.1.0. - [Release notes](https://github.com/codecov/codecov-action/releases) - [Changelog](https://github.com/codecov/codecov-action/blob/master/CHANGELOG.md) - [Commits](codecov/codecov-action@v3.0.0...v3.1.0) --- updated-dependencies: - dependency-name: codecov/codecov-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
Added PostgreSQL binaries to the PATH and removed the use of msys2-keyring
* Format CHANGELOG
The out-of-order 9.0.1 patch release causes our version numbers for pre-releases to break the "higher version number means more recent" promise. We discussed elsewhere (can't find it right now) why we need to tag the pre-release version numbers the way we do now, i.e. a 9.0.0.20220630 pre-release needs to be "bigger" than 9.0.0 - and smaller than 10.0.0. That's why 10.0.0.20220630 as a pre-release before 10.0.0 doesn't work. But now 9.0.1 came in, which only contains a small subset of changes compared to any 9.0.0.xxx pre-release. So 9.0.1 is not more advanced than 9.0.0.202205xx. But automatic dependency update tools like renovate or dependabot or whatever won't pick up on that.. so they will suggest an "update" from 9.0.0.xxx to 9.0.1 - which breaks things. This is quite annoying. We shouldn't not make any releases out-of-order and stick with a linear branch history. A practical approach to ease part of the problem would be to immediately release a new pre-release 9.0.1.20220630. This would then supersede 9.0.1 again. But this will not solve the general problem, that our version history is now not consistent anymore. |
Done: https://github.com/PostgREST/postgrest/releases/tag/v9.0.1.20220630
Hm, does dependabot work for upgrades on binaries/executables as well? I thought it was only for libraries. Also, does it pull pre-releases? If it sticks to releases only then there shouldn't be a problem.
I thought it would be preferable to have an out-of-order patch release than two consecutive major releases. I guess we just need to be more careful in merging breaking changes. I do agree in sticking to linear history. This was an exceptional case and it does require some extra work to make it happen, I don't think we'll do it again.
Maybe we should document the release rules/process in https://github.com/PostgREST/postgrest/blob/main/.github/CONTRIBUTING.md |
Thanks.
I'm using renovate, which is highly configurable and can update a lot of stuff. I'm using an "infrastructure as code" approach so everything that runs on my servers is defined in a git repo. The repo is updated via PRs by renovate and synced with flux to the kubernetes cluster. So whenever a new postgrest docker image is released, I get automated updates / PRs.
Well, how would it be able to tell that it's a pre-release? It's just another regular version, but with 4 numbers. And I actually want to use pre-releases. Otherwise I'd be missing a lot of features, due to our low release frequency. I just don't want to have an automated downgrade inbetween... |
Testing cherry picking fixes to release the PATCH version v9.0.1
Applied most commits in this range: ab90bd2 - 6b5370f
excluding the features, breaking changes and other commits related to those. After that last commit there are many features implemented, so I only cherry-picked some small fixes and the relevant commits to the CI files (for this PR to run the tests).
Fixes included: