Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Contributor roles #268

Closed
wants to merge 18 commits into from
Closed

Contributor roles #268

wants to merge 18 commits into from

Conversation

Scrumplex
Copy link
Member

No description provided.

@Scrumplex Scrumplex force-pushed the feature/contributor-roles branch 4 times, most recently from 36d27dd to 457f55b Compare October 11, 2023 19:58
@Scrumplex Scrumplex marked this pull request as ready for review October 13, 2023 07:49
ryanccn
ryanccn reviewed Oct 13, 2023
View reviewed changes
src/config.ts Outdated Show resolved Hide resolved
TheKodeToad
TheKodeToad approved these changes Nov 12, 2023
View reviewed changes
Copy link
Member

@TheKodeToad TheKodeToad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Toad's official seal of approval
(I do not have much knowledge in this area)
Just one suggestion that may improve code quality but it seems you intentionally avoided?

src/server.ts Show resolved Hide resolved
@TheKodeToad
Copy link
Member

Conflicts with main!

@Scrumplex
refactor: move env vars into config.ts
5c6dc7a 
Signed-off-by: Sefa Eyeoglu <[email protected]>
@Scrumplex
feat: register role connection metadata
c945cab 
Signed-off-by: Sefa Eyeoglu <[email protected]>
@Scrumplex
feat: initial implementation of role connection flow
84d4da6 
Signed-off-by: Sefa Eyeoglu <[email protected]>
@Scrumplex
fix: remove baseUrl config
00e0076 
Signed-off-by: Sefa Eyeoglu <[email protected]>
@Scrumplex
fix: send 200 when authorizing
687c52e 
Signed-off-by: Sefa Eyeoglu <[email protected]>
@Scrumplex
feat: initial implementation of GitHub check
4b44627 
Signed-off-by: Sefa Eyeoglu <[email protected]>
@Scrumplex
refactor: move steps into functions
7198e5b 
Signed-off-by: Sefa Eyeoglu <[email protected]>
@Scrumplex
refactor(nix): switch to flake-parts, add redis
52059da 
Signed-off-by: Sefa Eyeoglu <[email protected]>
@Scrumplex
feat: store tokens in Redis
fb8cad0 
Signed-off-by: Sefa Eyeoglu <[email protected]>
@Scrumplex
feat: cache GitHub contributors in Redis
c904300 
Signed-off-by: Sefa Eyeoglu <[email protected]>
@Scrumplex
refactor: switch to fastify
6eca1cd 
Signed-off-by: Sefa Eyeoglu <[email protected]>
@Scrumplex
refactor: banish axios from these lands
d3ef340 
Signed-off-by: Sefa Eyeoglu <[email protected]>
@Scrumplex
feat: fetch Github contributors periodically
2e2677a 
Signed-off-by: Sefa Eyeoglu <[email protected]>
@Scrumplex
fix: load dotenv early
b3fe9bc 
Signed-off-by: Sefa Eyeoglu <[email protected]>
@Scrumplex
chore: remove unused dependency
a81fa91 
Signed-off-by: Sefa Eyeoglu <[email protected]>
@Scrumplex
fix: rename expressPort to httpPort
9286a05 
Signed-off-by: Sefa Eyeoglu <[email protected]>
@Scrumplex Scrumplex force-pushed the feature/contributor-roles branch from 6854c7c to 9286a05 Compare November 15, 2023 15:33
@TheKodeToad
Copy link
Member

Hopefully I didn't mess up the merging... :P

@TheKodeToad TheKodeToad force-pushed the feature/contributor-roles branch from 9bb5b4a to 60424e3 Compare November 18, 2023 12:39
@getchoo getchoo mentioned this pull request Dec 3, 2023
Merged
11 tasks
@Scrumplex Scrumplex closed this Mar 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryanccn ryanccn ryanccn left review comments

@TheKodeToad TheKodeToad TheKodeToad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Scrumplex @TheKodeToad @ryanccn