Introduction of CRTT0Tagging module. #774
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 14 commits
October 15, 2024 19:52
…hich create T0 objects for tracks matched with CRTs. It also create associations between tracks, CRT Hits and T0 objects.
… Compilation works.
…There is still one issue: after processing the first event returns: No product is registered for CRTT0Tagging
…acks (cathode crossers) when the time difference between the two is bigget than 10 us
…nfiguration with explanations.
… which include extra inforamations on the CRT-TPC match.
…the data product. Another improvements which is introduced is the access of truth level information for MC. In particular, I set up a variabile which is called TruthMatch which address whether at truth level the CRT hit and the Tracks are generated by the same Geant4 ID particle. So far, this variable is only stored in the tree, but I am planning to include it in the icart::CRTTPCMatchingInfo object
PetrilloAtWork
requested changes
Jan 8, 2025
There was a problem hiding this comment.
I have left std::numeric_limits<std::int8_t>::max() comments.
The most relevant is that I am confused about the new data product compared to the old one: same name, completely different content, deceiving schema evolution.
It may be that you had already explained that, if so I can't find where.
I am of course available for helping with the resolution of the comments.
added 9 commits
January 10, 2025 15:45
…mportant things: structs have been changed quite a bit, in addition I am now willingly saving information of the full PCA analysis and I am saving also second and third eigenValues/Vectors.
…nluca. In particular, software related to CRT Hit transformation has beend moved from the namespace dedicated to the matching, to a new one dedicated to data related tools
…few things are left to deal with: icarus_data and addressing legacy code.
…e information which were need have been added to an SBNObj (CRTT0TaggingInfo). In this way this object is not changed wrt legacy CRTTagging code. Additionally in this commit In the CRTT0TaggingInfo also the way the track was fitted is stored.
…racks (SBND like)
… the Stage1 definitions and included the new CRTT0Tagging one
…Ps, association of Tracks/PFP with CRTT0TaggingInfo
… specifically for the MC truth has been created.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduce a new producer module: CRTT0Tagging
This new module produces an association with tracks and and a T0 object following CRT-TPC association. It also fills a new icarus only data product with some summary information on the result of the match, this product is called CRTTPCMatchingInfo.
Additionally associations of anab::T0 and tracks and CRT and CRTTPCMatchingInfo are stored.
This PR introduces also the CRTMatching class which contains the matching functions. In future, TripleMatching will exploits the same functions, this is why, for example, there is the GetTrackBarycenter function which is not yet used.
A brief story: there is an already existent CRTT0Matching object, but that is very outdated and not mantained anymore. The problem is that that product is widely used around our code. Not to create confusion, I added here the updated version under a new name. The new matching is based on a PCA fit of the track direction and extrapolated to the CRT plane of the CRT hit under test.
At the state of this PR, the module lives on its own and it is not included into any stage0/1/caf definitions. It is there for people to use if needed. I will follow up, once this PR is considered ok, with an additional one which starts to implement the CRTTagging of the TPC tracks in our production and analysis flow.
This module works on both data and MC! The only caveat is that for data there is an additional implementation which re-align the Top CRT modules to the TPCs, following to the alignment campaign which I performed on Run2 data. It is expected that for Run3 a new alignment txt file will be produced, but I do not have yet since we did not reprocess Run3, so using the Run2 one is way better than not using it.
I believe this SBN DocDB summarizes everything that it is introduced here: https://sbn-docdb.fnal.gov/cgi-bin/sso/RetrieveFile?docid=38008&filename=TPCCalibrationWithCRTTPCTaggedTracks.pdf&version=1