Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduction of CRTT0Tagging module. #774

Open
wants to merge 28 commits into
base: develop
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
a888624
First commit to include CRTMatchingUtils
Oct 15, 2024
75cac79
completed the utils files and corrected errors for the compiler
Oct 16, 2024
e1ae4c4
This commit includes the introduction of a new module: CRTT0Tagging w…
Oct 17, 2024
9f75b42
adding to CMake the producer and making compiler happy for CRTMatchin…
Oct 17, 2024
b851d07
updates
Oct 17, 2024
3fa0f3f
Some More changes but the compiler still does not like it.
Oct 17, 2024
4333f9c
Moved CRTMatching namespace to a class. Adjusted CRTT0Tagging module.…
Oct 21, 2024
a0dc62d
updated the fcl files, now the lar command gets correctly exectuded. …
Oct 22, 2024
6f40e85
This commit makes sure the correct data product is stored.
Oct 22, 2024
69b0cbd
Removed some magic numbers and added to configuration parameters
Oct 22, 2024
1762068
added a check that rejects CRT and Track combinations for T0Tagged tr…
Oct 22, 2024
571264b
I think I removed all the magic numbers and added them to fcl file co…
Oct 23, 2024
f5384b9
now it works also on MC
Oct 23, 2024
39bd654
Ok now everything works fine and an additional data product is stored…
Oct 23, 2024
b7783d4
This Commit introduces a summary tree which gets produced along with …
Oct 25, 2024
d8e4334
Addressing some of the easier comments from Gianluca
Jan 10, 2025
10d8bd3
This commits includes a lot of Gianluca's requests
Jan 14, 2025
26d3850
This is another round of commit. Last of today. In this one several i…
Jan 14, 2025
2ff70c5
This commits includes other changes and improvements requested by Gia…
Jan 15, 2025
8d16d4f
This Commit includes the final changes requested from Gianluca. Only …
Jan 16, 2025
8fe71dc
restore deleted files
Jan 17, 2025
37eaf3e
This commit include a reverse on the CRTTPCMatchingInfo IcarusObj. Th…
Jan 20, 2025
1edc609
added the matching method, single crt hits (icarus like) or with crtt…
Jan 20, 2025
6c67527
I (quote) think (quote) that I removed the CRTT0Matching module frome…
Jan 20, 2025
a52ab07
removal of Top CRT Correction By TPC from icaruscode, will go in icar…
Jan 21, 2025
b26a5a0
Introduced a function that checks if the Top CRT corrections were rea…
Jan 21, 2025
7792a31
Introduction of additional products, namely association of T0 with PF…
Jan 22, 2025
bb3ad64
This change reflect the changes into SBNObj, where a new data product…
Feb 3, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions fcl/reco/Definitions/stage1_icarus_defs.fcl
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,11 @@
#include "flashmatch_simple_icarus.fcl"
#include "crttrackproducer_icarus.fcl"
#include "crtbacktracker_icarus.fcl"
### FPoppi : The following CRT matching algorithms are deprecated.
#include "crtt0matchingalg_icarus.fcl"
#include "crtt0producer_icarus.fcl"
### FPoppi : The following one is mantained.
#include "crtt0tagging.fcl"
## The below can be found from the softlink to Supera in sbncode
#include "supera_modules.fcl"
#include "crtpmtmatching_parameters.fcl"
Expand Down Expand Up @@ -65,9 +68,11 @@ icarus_stage1_producers:

## crt producer
crttrack: @local::standard_crttrackproducer
CRTT0Matching: @local::standard_crtt0producer
CRTT0MatchingW: @local::standard_crtt0producerW
CRTT0MatchingE: @local::standard_crtt0producerE
### FPoppi: the following are deprecated (and the one above not mantained)
## CRTT0Matching: @local::standard_crtt0producer
## CRTT0MatchingW: @local::standard_crtt0producerW
## CRTT0MatchingE: @local::standard_crtt0producerE
CRTT0Tagging: @local::icarus_crtt0tagging_data

tpcpmtbarycentermatchCryoE: @local::data_tpcpmtbarycentermatchproducer_east
tpcpmtbarycentermatchCryoW: @local::data_tpcpmtbarycentermatchproducer_west
Expand Down Expand Up @@ -223,6 +228,8 @@ icarus_crtt0match: [CRTT0Matching]

icarus_crtt0match_eff: [CRTT0MatchingE, CRTT0MatchingW]

icarus_crtt0tagging: [CRTT0Tagging]

### Below we include overrides for the modules above

## Overrides for filtering of cluster3D hits
Expand Down
2 changes: 1 addition & 1 deletion fcl/reco/Stage1/Run1/stage1_multiTPC_icarus_gauss.fcl
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ physics.reco: [ @sequence::icarus_filter_cluster3D,
@sequence::icarus_pandora_Gauss,
@sequence::icarus_reco_fm,
@sequence::icarus_crttrack,
@sequence::icarus_crtt0match,
@sequence::icarus_crtt0tagging,
caloskimCalorimetryCryoE, caloskimCalorimetryCryoW]

physics.outana: [ caloskimE, caloskimW, simpleLightAna, CRTDataAnalysis]
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ physics.reco: [ @sequence::icarus_filter_cluster3D,
@sequence::icarus_pandora_Gauss,
@sequence::icarus_reco_fm,
@sequence::icarus_crttrack,
@sequence::icarus_crtt0match,
@sequence::icarus_crtt0tagging,
caloskimCalorimetryCryoE, caloskimCalorimetryCryoW]

physics.outana: [ caloskimE, caloskimW, simpleLightAna, CRTDataAnalysis, CRTAnalysis]
Expand Down
2 changes: 1 addition & 1 deletion fcl/reco/Stage1/Run2/stage1_run2_icarus.fcl
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ physics.reco: [ @sequence::icarus_filter_cluster3D,
@sequence::icarus_reco_fm,
@sequence::icarus_tpcpmtbarycentermatch,
@sequence::icarus_crttrack,
@sequence::icarus_crtt0match,
@sequence::icarus_crtt0tagging,
caloskimCalorimetryCryoE, caloskimCalorimetryCryoW]

physics.outana: [ @sequence::icarus_analysis_modules ]
Expand Down
132 changes: 40 additions & 92 deletions icaruscode/CRT/CMakeLists.txt
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@

add_subdirectory(CRTUtils)
add_subdirectory(CRTDecoder)

add_subdirectory(CRTLegacyCode)

art_make(
NO_PLUGINS
Expand All @@ -11,7 +11,6 @@ art_make(
CRTDetSim_module.cc
CRTSimHitProducer_module.cc
CRTTrueHitProducer_module.cc
CRTTzeroProducer_module.cc
CRTTrackProducer_module.cc
CRTSimAnalysis_module.cc
CRTDataAnalysis_module.cc
Expand All @@ -20,7 +19,6 @@ art_make(
CRTAutoVeto_module.cc
FlashResAna_module.cc
PhotBackground_module.cc
CRTT0Matching_module.cc
CRTTPCMatchingAna_module.cc
CRTPMTMatchingAna_module.cc
CRTTPCTruthEff_module.cc
Expand Down Expand Up @@ -62,6 +60,25 @@ art_make_library(
cetlib::cetlib
)

art_make_library(
LIBRARY_NAME
icaruscode_CRTMatchingUtils
SOURCE
CRTUtils/CRTMatchingUtils.cxx
LIBRARIES
fhiclcpp::fhiclcpp
canvas::canvas
lardataobj::RecoBase
lardata::Utilities
lardata::ArtDataHelper
larcorealg::Geometry
lardataalg::DetectorInfo
sbnobj::Common_CRT
cetlib::cetlib
messagefacility::MF_MessageLogger
ROOT::Matrix
)

cet_build_plugin(CRTGeometryHelper art::service
LIBRARIES
larcorealg::Geometry
Expand Down Expand Up @@ -129,23 +146,6 @@ cet_build_plugin( CRTTrueHitProducer art::module
cetlib::cetlib
)

cet_build_plugin(CRTTzeroProducer art::module
LIBRARIES
larcorealg::Geometry
icaruscode_CRT
sbnobj::ICARUS_CRT
sbnobj::Common_CRT
art_root_io::TFileService_service
lardataalg::DetectorInfo
nurandom::RandomUtils_NuRandomService_service
art::Framework_Services_Registry
art::Framework_Services_Optional_RandomNumberGenerator_service
messagefacility::MF_MessageLogger
messagefacility::headers
CLHEP::CLHEP
lardata::Utilities
)

cet_build_plugin(CRTTrackProducer art::module
LIBRARIES
larcorealg::Geometry
Expand Down Expand Up @@ -382,78 +382,6 @@ cet_build_plugin( PhotBackground art::module
ROOT::Tree
)

cet_build_plugin(CRTT0Matching art::module
LIBRARIES
icaruscode_CRTData
icaruscode_CRT
sbnobj::Common_CRT
icaruscode_CRTUtils
larcore::Geometry_Geometry_service
larsim::Simulation lardataobj::Simulation
larsim::MCCheater_BackTrackerService_service
larsim::MCCheater_ParticleInventoryService_service
lardata::Utilities
larevt::Filters
lardataobj::RawData
lardataobj::RecoBase
lardataobj::AnalysisBase
lardata::RecoObjects
larpandora::LArPandoraInterface
larcorealg::Geometry
nusimdata::SimulationBase
art::Framework_Core
art::Framework_Principal
art::Framework_Services_Registry
art_root_io::tfile_support
art_root_io::TFileService_service
art::Persistency_Common canvas::canvas
art::Persistency_Provenance
art::Utilities
messagefacility::MF_MessageLogger
ROOT::Core
ROOT::Geom
ROOT::XMLIO
ROOT::Gdml
ROOT::Tree
ROOT::Spectrum
ROOT::RooFit
ROOT::RooFitCore
)


cet_build_plugin(CRTT0MatchingAna art::module
LIBRARIES
sbnobj::ICARUS_CRT
icaruscode_CRT
sbnobj::Common_CRT
icaruscode_CRTUtils
larcorealg::Geometry
larcore::Geometry_Geometry_service
larsim::Simulation lardataobj::Simulation
larsim::MCCheater_BackTrackerService_service
larsim::MCCheater_ParticleInventoryService_service
lardata::Utilities
larevt::Filters
lardataobj::RawData
lardataobj::RecoBase
lardataobj::AnalysisBase
lardata::RecoObjects
larpandora::LArPandoraInterface
larcorealg::Geometry
nusimdata::SimulationBase
art::Persistency_Common canvas::canvas
art::Persistency_Provenance
art::Utilities
ROOT::Core
ROOT::Tree
ROOT::Geom
ROOT::XMLIO
ROOT::Gdml
ROOT::Spectrum
ROOT::RooFit
ROOT::RooFitCore
)

cet_build_plugin(CRTTPCMatchingAna art::module
LIBRARIES
sbnobj::ICARUS_CRT
Expand Down Expand Up @@ -517,6 +445,26 @@ simple_plugin(CRTTPCTruthEff module

)

cet_build_plugin(CRTT0Tagging art::module
LIBRARIES
icaruscode::IcarusObj
icaruscode_CRTMatchingUtils
icaruscode_CRTUtils
sbnobj::Common_CRT
larcorealg::Geometry
lardataalg::DetectorInfo
larcore::Geometry_Geometry_service
larsim::Simulation lardataobj::Simulation
larsim::MCCheater_BackTrackerService_service
larsim::MCCheater_ParticleInventoryService_service
lardata::headers
lardataobj::RecoBase
lardataobj::AnalysisBase
nusimdata::SimulationBase
art_root_io::TFileService_service
art_root_io::tfile_support
ROOT::Tree
)

install_headers()
install_fhicl()
Expand Down
93 changes: 93 additions & 0 deletions icaruscode/CRT/CRTLegacyCode/CMakeLists.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,93 @@
cet_build_plugin(CRTTzeroProducer art::module
LIBRARIES
larcorealg::Geometry
icaruscode_CRT
sbnobj::ICARUS_CRT
sbnobj::Common_CRT
art_root_io::TFileService_service
lardataalg::DetectorInfo
nurandom::RandomUtils_NuRandomService_service
art::Framework_Services_Registry
art::Framework_Services_Optional_RandomNumberGenerator_service
messagefacility::MF_MessageLogger
messagefacility::headers
CLHEP::CLHEP
lardata::Utilities
)

cet_build_plugin(CRTT0Matching art::module
LIBRARIES
icaruscode_CRTData
icaruscode_CRT
sbnobj::Common_CRT
icaruscode_CRTUtils
larcore::Geometry_Geometry_service
larsim::Simulation lardataobj::Simulation
larsim::MCCheater_BackTrackerService_service
larsim::MCCheater_ParticleInventoryService_service
lardata::Utilities
larevt::Filters
lardataobj::RawData
lardataobj::RecoBase
lardataobj::AnalysisBase
lardata::RecoObjects
larpandora::LArPandoraInterface
larcorealg::Geometry
nusimdata::SimulationBase
art::Framework_Core
art::Framework_Principal
art::Framework_Services_Registry
art_root_io::tfile_support
art_root_io::TFileService_service
art::Persistency_Common canvas::canvas
art::Persistency_Provenance
art::Utilities
messagefacility::MF_MessageLogger
ROOT::Core
ROOT::Geom
ROOT::XMLIO
ROOT::Gdml
ROOT::Tree
ROOT::Spectrum
ROOT::RooFit
ROOT::RooFitCore
)


cet_build_plugin(CRTT0MatchingAna art::module
LIBRARIES
sbnobj::ICARUS_CRT
icaruscode_CRT
sbnobj::Common_CRT
icaruscode_CRTUtils
larcorealg::Geometry
larcore::Geometry_Geometry_service
larsim::Simulation lardataobj::Simulation
larsim::MCCheater_BackTrackerService_service
larsim::MCCheater_ParticleInventoryService_service
lardata::Utilities
larevt::Filters
lardataobj::RawData
lardataobj::RecoBase
lardataobj::AnalysisBase
lardata::RecoObjects
larpandora::LArPandoraInterface
larcorealg::Geometry
nusimdata::SimulationBase
art::Persistency_Common canvas::canvas
art::Persistency_Provenance
art::Utilities
ROOT::Core
ROOT::Tree
ROOT::Geom
ROOT::XMLIO
ROOT::Gdml
ROOT::Spectrum
ROOT::RooFit
ROOT::RooFitCore
)


install_headers()
install_fhicl()
install_source()
Loading