Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Transaction Date #17

Merged
merged 4 commits into from
Jan 19, 2024
Merged

feat: add Transaction Date #17

merged 4 commits into from
Jan 19, 2024

Conversation

nnsier
Copy link
Collaborator

@nnsier nnsier commented Jan 17, 2024

Description

This PR enhances the functionality of the strings library to include Transaction_Date as a customizable string.
This will allow our server to verify that the new Transaction_Date is a valid string, and for our clients to display the customized string.

Copy link
Member

@nexdrew nexdrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments, particularly the first two.

src/index.js Show resolved Hide resolved
src/index.js Show resolved Hide resolved
src/index.js Show resolved Hide resolved
@nnsier
Copy link
Collaborator Author

nnsier commented Jan 19, 2024

I am not an authorized user so I cannot merge :(

@nnsier nnsier merged commit 0c2d127 into master Jan 19, 2024
6 checks passed
@nnsier nnsier deleted the transaction_date branch January 19, 2024 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants