Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove removed_in version of deprecated settings #1423

Merged
merged 4 commits into from
Feb 4, 2024

Conversation

alex-harvey-z3q
Copy link
Contributor

@alex-harvey-z3q alex-harvey-z3q commented Jan 18, 2024

This removes the removed_in version of role_arn, iam_role, iam_role_session_duration, and template_path, to give consumers more time to upgrade.

Related to #1406

PR Checklist

  • Wrote a good commit message & description [see guide below].
  • Commit message starts with [Resolve #issue-number].
  • Added/Updated unit tests.
  • Added/Updated integration tests (if applicable).
  • All unit tests (poetry run tox) are passing.
  • Used the same coding conventions as the rest of the project.
  • The new code passes pre-commit validations (poetry run pre-commit run --all-files).
  • The PR relates to only one subject with a clear title.
    and description in grammatically correct, complete sentences.

Approver/Reviewer Checklist

  • Before merge squash related commits.

Other Information

Guide to writing a good commit

This removes the removed_in version of role_arn, iam_role and
iam_role_session_duration, to give consumers more time to upgrade.
@alex-harvey-z3q alex-harvey-z3q changed the title Ah/remove deprecation Remove removed_in version of role_arn Jan 19, 2024
@alex-harvey-z3q alex-harvey-z3q changed the title Remove removed_in version of role_arn Remove removed_in version of deprecated settings Jan 19, 2024
@zaro0508 zaro0508 merged commit b91915f into Sceptre:master Feb 4, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants