Add custom request to return LSP internal state #3194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinistock
added
the
server
Graphite App
How to use the Graphite Merge QueueAdd the label graphite-merge to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
vinistock
force-pushed
the
02-13-add_custom_command_to_return_lsp_internal_state
branch
from
139c44a to
2afdeb7
Compare
andyw8
approved these changes
Feb 13, 2025
Merge activity
|
vinistock
force-pushed
the
02-13-add_custom_command_to_return_lsp_internal_state
branch
from
2afdeb7 to
cf32d6a
Compare
vinistock
changed the title
vinistock
force-pushed
the
02-13-add_custom_command_to_return_lsp_internal_state
branch
from
cf32d6a to
2fd31fd
Compare
### Motivation Diagnosing concurrency issues in the LSP tends to be very difficult and without more detailed information about the state of the language server, it becomes extra challenging to understand what's going on. Let's add a command to surface internal state information, which we can hook to a command in the extension. When users manage to reproduce the problem, they can invoke the command and provide richer details. ### Implementation The idea is to return internal state information that may be relevant to diagnose a corrupt state or crash. For now, I included the state of the worker, backtrace, size of the incoming queue and all stored documents. This should hopefully help us understand the following things: 1. Is the worker dead or just stuck? 2. If it's stuck, where is it stuck? Is the queue increasing causing the worker to get backlogged? 3. Why did we get stuck? Are the documents we stored in an out of sync state with the client? ### Automated Tests Added a test.
graphite-app
bot
force-pushed
the
02-13-add_custom_command_to_return_lsp_internal_state
branch
from
2fd31fd to
632113a
Compare
graphite-app
bot
deleted the
02-13-add_custom_command_to_return_lsp_internal_state
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Diagnosing concurrency issues in the LSP tends to be very difficult and without more detailed information about the state of the language server, it becomes extra challenging to understand what's going on.
Let's add a command to surface internal state information, which we can hook to a command in the extension. When users manage to reproduce the problem, they can invoke the command and provide richer details.
Implementation
The idea is to return internal state information that may be relevant to diagnose a corrupt state or crash. For now, I included the state of the worker, backtrace, size of the incoming queue and all stored documents.
This should hopefully help us understand the following things:
Automated Tests
Added a test.