Add command to show LSP's internal state for diagnosing issues #3195
+55
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
How to use the Graphite Merge QueueAdd the label graphite-merge to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
vinistock
added
vscode
Graphite App
vinistock
force-pushed
the
02-13-add_custom_command_to_return_lsp_internal_state
branch
from
139c44a to
2afdeb7
Compare
vinistock
force-pushed
the
02-13-add_command_to_show_lsp_s_internal_state_for_diagnosing_issues
branch
from
651a9de to
449cb8e
Compare
vinistock
force-pushed
the
02-13-add_custom_command_to_return_lsp_internal_state
branch
from
2afdeb7 to
cf32d6a
Compare
vinistock
force-pushed
the
02-13-add_command_to_show_lsp_s_internal_state_for_diagnosing_issues
branch
from
449cb8e to
5f06094
Compare
vinistock
force-pushed
the
02-13-add_custom_command_to_return_lsp_internal_state
branch
from
cf32d6a to
2fd31fd
Compare
vinistock
force-pushed
the
02-13-add_command_to_show_lsp_s_internal_state_for_diagnosing_issues
branch
from
5f06094 to
1eeb605
Compare
vinistock
changed the base branch from
02-13-add_custom_command_to_return_lsp_internal_state
to
graphite-base/3195
vinistock
force-pushed
the
02-13-add_command_to_show_lsp_s_internal_state_for_diagnosing_issues
branch
from
1eeb605 to
00c70bc
Compare
vinistock
force-pushed
the
graphite-base/3195
branch
from
2fd31fd to
632113a
Compare
vinistock
force-pushed
the
02-13-add_command_to_show_lsp_s_internal_state_for_diagnosing_issues
branch
from
00c70bc to
7542c66
Compare
amomchilov
approved these changes
Feb 14, 2025
Merge activity
|
### Motivation Add a command to trigger the new custom diagnose request, so that it's easy to see the information at a glance. ### Implementation It's the same implementation as show syntax tree, we use a custom resource to show a read-only document containing the relevant information. ### Manual Tests 1. Launch the extension on this branch 2. On the second VS Code window, open the Ruby LSP code itself (you need the server changes to verify all pieces together) 3. Invoke the new command 4. Verify you see the internal state of the server
graphite-app
bot
force-pushed
the
02-13-add_command_to_show_lsp_s_internal_state_for_diagnosing_issues
branch
from
7542c66 to
2860c05
Compare
Morriar
approved these changes
Feb 14, 2025
vinistock
deleted the
02-13-add_command_to_show_lsp_s_internal_state_for_diagnosing_issues
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Add a command to trigger the new custom diagnose request, so that it's easy to see the information at a glance.
Implementation
It's the same implementation as show syntax tree, we use a custom resource to show a read-only document containing the relevant information.
Manual Tests