Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement] Allow CN to run script #44982

Merged
merged 1 commit into from
Apr 29, 2024
Merged

[Enhancement] Allow CN to run script #44982

merged 1 commit into from
Apr 29, 2024

Conversation

decster
Copy link
Contributor

@decster decster commented Apr 29, 2024 •
edited
Loading

Why I'm doing:

MySQL [(none)]> admin execute on 10006 'System.print(ExecEnv.get_stack_trace_for_all_threads())';
ERROR 1064 (HY000): node not found: 10006

What I'm doing:

Allow CN to run script

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

@github-actions github-actions bot added the 2.5 label Apr 29, 2024
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@github-actions GitHub Actions
Copy link

[BE Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@github-actions GitHub Actions
Copy link

[FE Incremental Coverage Report]

✅ pass : 1 / 1 (100.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/qe/ExecuteScriptExecutor.java 1 1 100.00% []

@decster decster merged commit ed6a72c into StarRocks:main Apr 29, 2024
50 checks passed
@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.3

@github-actions github-actions bot removed the 3.3 label Apr 29, 2024
@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.2

@github-actions github-actions bot removed the 3.2 label Apr 29, 2024
@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.1

@github-actions github-actions bot removed the 3.1 label Apr 29, 2024
@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.0

@github-actions github-actions bot removed the 3.0 label Apr 29, 2024
@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-2.5

@github-actions github-actions bot removed the 2.5 label Apr 29, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Apr 29, 2024 •
edited
Loading

backport branch-3.3

✅ Backports have been created

@mergify Mergify
Copy link
Contributor

mergify bot commented Apr 29, 2024 •
edited
Loading

backport branch-3.2

✅ Backports have been created

@mergify Mergify
Copy link
Contributor

mergify bot commented Apr 29, 2024 •
edited
Loading

backport branch-3.1

✅ Backports have been created

@mergify Mergify
Copy link
Contributor

mergify bot commented Apr 29, 2024 •
edited
Loading

backport branch-3.0

✅ Backports have been created

@mergify Mergify
Copy link
Contributor

mergify bot commented Apr 29, 2024 •
edited
Loading

backport branch-2.5

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Apr 29, 2024
@decster @mergify
[Enhancement] Allow CN to run script (#44982)
7c0a09c 
Signed-off-by: Binglin Chang <[email protected]>
(cherry picked from commit ed6a72c)
@mergify mergify bot mentioned this pull request Apr 29, 2024
Merged
42 tasks
This was referenced Apr 29, 2024
Merged
Merged
mergify bot pushed a commit that referenced this pull request Apr 29, 2024
@decster @mergify
[Enhancement] Allow CN to run script (#44982)
3024413 
Signed-off-by: Binglin Chang <[email protected]>
(cherry picked from commit ed6a72c)

# Conflicts:
#	fe/fe-core/src/main/java/com/starrocks/qe/ExecuteScriptExecutor.java
@mergify mergify bot mentioned this pull request Apr 29, 2024
Merged
42 tasks
decster added a commit that referenced this pull request Apr 29, 2024
@decster
[Enhancement] Allow CN to run script (#44982)
71216c9 
Signed-off-by: Binglin Chang <[email protected]>
(cherry picked from commit ed6a72c)
wanpengfei-git pushed a commit that referenced this pull request Apr 29, 2024
@mergify @decster
[Enhancement] Allow CN to run script (backport #44982) (#44993)
c39ac1c 
Co-authored-by: Binglin Chang <[email protected]>
mergify bot pushed a commit that referenced this pull request Apr 29, 2024
@decster @mergify
[Enhancement] Allow CN to run script (#44982)
1876b4e 
Signed-off-by: Binglin Chang <[email protected]>
(cherry picked from commit ed6a72c)

# Conflicts:
#	fe/fe-core/src/main/java/com/starrocks/qe/ExecuteScriptExecutor.java
@mergify mergify bot mentioned this pull request Apr 29, 2024
Merged
42 tasks
decster added a commit that referenced this pull request Apr 29, 2024
@decster
[Enhancement] Allow CN to run script (#44982)
0b9a634 
Signed-off-by: Binglin Chang <[email protected]>
(cherry picked from commit ed6a72c)
decster added a commit that referenced this pull request Apr 29, 2024
@decster
[Enhancement] Allow CN to run script (#44982)
bb12fa3 
Signed-off-by: Binglin Chang <[email protected]>
(cherry picked from commit ed6a72c)
@github-actions github-actions bot added the 3.0 label Apr 29, 2024
wanpengfei-git pushed a commit that referenced this pull request Apr 29, 2024
@mergify @decster
[Enhancement] Allow CN to run script (backport #44982) (#44994)
4b3afb0 
Co-authored-by: Binglin Chang <[email protected]>
decster added a commit that referenced this pull request Apr 30, 2024
@decster
[Enhancement] Allow CN to run script (#44982)
0218568 
Signed-off-by: Binglin Chang <[email protected]>
(cherry picked from commit ed6a72c)
decster added a commit that referenced this pull request Apr 30, 2024
@decster
[Enhancement] Allow CN to run script (#44982)
8673f60 
Signed-off-by: Binglin Chang <[email protected]>
(cherry picked from commit ed6a72c)
wanpengfei-git pushed a commit that referenced this pull request Apr 30, 2024
@mergify @decster
[Enhancement] Allow CN to run script (backport #44982) (#44995)
8093e01 
Co-authored-by: Binglin Chang <[email protected]>
wanpengfei-git pushed a commit that referenced this pull request Apr 30, 2024
@mergify @decster
[Enhancement] Allow CN to run script (backport #44982) (#44996)
f93e792 
Co-authored-by: Binglin Chang <[email protected]>
node pushed a commit to vivo/starrocks that referenced this pull request May 9, 2024
@decster @node
[Enhancement] Allow CN to run script (StarRocks#44982)
3b2003e 
Signed-off-by: Binglin Chang <[email protected]>
kevincai pushed a commit that referenced this pull request May 10, 2024
@mergify @decster
[Enhancement] Allow CN to run script (backport #44982) (#44992)
25116c9 
Co-authored-by: Binglin Chang <[email protected]>
mergify bot added a commit that referenced this pull request May 10, 2024
@mergify
[Enhancement] Allow CN to run script (backport #44982) (#44992)
8cf4b0e 
Co-authored-by: Binglin Chang <[email protected]>
(cherry picked from commit 25116c9)

# Conflicts:
#	fe/fe-core/src/main/java/com/starrocks/qe/ExecuteScriptExecutor.java
@mergify mergify bot mentioned this pull request May 10, 2024
Closed
42 tasks
chaoyli pushed a commit to chaoyli/starrocks that referenced this pull request May 28, 2024
@mergify @decster @srlch
[Enhancement] Allow CN to run script (backport StarRocks#44982) (Star…
e993900 
…Rocks#44993)

Co-authored-by: Binglin Chang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trueeyu trueeyu trueeyu approved these changes

@imay imay imay approved these changes

Assignees

@decster decster

Labels
2.5-merged 2.5 3.0-merged 3.0 3.1-merged 3.1 3.2-merged 3.2 3.3-merged 3.3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@decster @imay @trueeyu