Feat: complete trip space page #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
SKY-PEY
previously approved these changes
Jan 14, 2024
|
|
||
| import { LeaveTripModalProps } from "@/types/modal"; | ||
|
|
||
| function LeaveTripModal({ isOpen, onClose }: LeaveTripModalProps) { |
There was a problem hiding this comment.
헉 저도 지금 이 모달 만들고 있었는데 혹시 모달뜨면서 바텀슬라이드 내려가는거 해보셨나요??ㅜ
모달이나 바텀슬라이드나 같은 onClose를 쓰니까 꼬이는 것 같더라구요,,,, 우선 지금 이것저것 해보는데 시간을 많이 빼앗겨서... 서현님은 어떻게 하시나 궁금했습니다😥
(수정)
방금 해결했습니다ㅎㅎ..!
HOOOO98
reviewed
Jan 15, 2024
src/pages/Trip/Trip.tsx
Outdated
There was a problem hiding this comment.
헉...여기서 컨플릭트가 나오네요ㅠㅠ
trip.tsx 최대한 안건드리려고 했는데 죄송합니다🥲
There was a problem hiding this comment.
괜찮습니다 ㅎㅎ #90 PR 머지 되면 conflict 해결할게요~
NamgungJongMin
previously approved these changes
Jan 15, 2024
HOOOO98
approved these changes
Jan 15, 2024
HOOOO98
approved these changes
Jan 15, 2024
Yamyam-code
approved these changes
Jan 15, 2024
JeongMin83
approved these changes
Jan 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
개요
여행 스페이스 페이지 마무리
close #91
스크린샷
주요 내용
고민한 점, 질문거리
⭐️ 여행 페이지 path 변경
명확한 네이밍을 위해
/carryout->/trip으로 변경했습니다. gnb path도 수정해두었습니다.혹시 다른 컴포넌트에서 carryout path를 쓰시는 분이 계시다면 변경 부탁드립니다 🙇🏻♀️