-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: complete trip space page #92
Merged
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
a8ce0a8
Feat: create leave trip modal
JSH99 1d8e050
Rename: change calender component from modal to page
JSH99 265d528
Faet: route trip space pages
JSH99 8abbb74
Fix: change overlapping style name
JSH99 9cc8ead
Fix: change overlapping style name
JSH99 60b3222
Feat: add navigate edit trip space component
JSH99 2fbe10a
Design: fix responsive design
JSH99 07b67a5
Fix: fix conflict
JSH99 52a1480
Fix: rename changed component name
JSH99 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14 changes: 0 additions & 14 deletions
14
src/components/TripSpace/EditBottomSlideContent/EditBottomSlideContent.tsx
This file was deleted.
Oops, something went wrong.
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,32 @@ | ||
import { useDisclosure } from "@chakra-ui/react"; | ||
import { useNavigate } from "react-router-dom"; | ||
|
||
import styles from "./EditTripSpace.module.scss"; | ||
|
||
import LeaveTripModal from "../LeaveTripModal/LeaveTripModal"; | ||
|
||
function EditTripSpace() { | ||
const navigate = useNavigate(); | ||
const { | ||
isOpen: isModalOpen, | ||
onOpen: onModalOpen, | ||
onClose: onModalClose, | ||
} = useDisclosure(); | ||
|
||
return ( | ||
<> | ||
<div className={styles.ContentContainer}> | ||
<button onClick={() => navigate("/trip/selectRegion")}> | ||
여행도시 편집 | ||
</button> | ||
<button onClick={() => navigate("/trip/selectDate")}> | ||
여행날짜 수정 | ||
</button> | ||
<button onClick={onModalOpen}>여행 나가기</button> | ||
</div> | ||
<LeaveTripModal isOpen={isModalOpen} onClose={onModalClose} /> | ||
</> | ||
); | ||
} | ||
|
||
export default EditTripSpace; |
68 changes: 68 additions & 0 deletions
68
src/components/TripSpace/LeaveTripModal/LeaveTripModal.tsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,68 @@ | ||
import { | ||
Button, | ||
Modal, | ||
ModalBody, | ||
ModalContent, | ||
ModalFooter, | ||
ModalHeader, | ||
} from "@chakra-ui/react"; | ||
|
||
import { LeaveTripModalProps } from "@/types/modal"; | ||
|
||
function LeaveTripModal({ isOpen, onClose }: LeaveTripModalProps) { | ||
return ( | ||
<Modal isOpen={isOpen} onClose={onClose} size="lg" isCentered> | ||
<ModalContent | ||
display="flex" | ||
flexDirection="column" | ||
alignItems="center" | ||
gap="1.2rem" | ||
borderRadius="16px" | ||
bg="neutral.0" | ||
p="32px" | ||
> | ||
<ModalHeader | ||
fontSize="subTitle" | ||
fontWeight="subTitle" | ||
lineHeight="subTitle" | ||
color="neutral.900" | ||
p="0" | ||
> | ||
여행을 나가시겠어요? | ||
</ModalHeader> | ||
<ModalBody | ||
fontSize="tabLabel" | ||
fontWeight="tabLabel" | ||
lineHeight="tabLabel" | ||
color="neutral.400" | ||
p="0" | ||
> | ||
<p>동행의 초대없이 다시 참여가 불가능합니다</p> | ||
</ModalBody> | ||
<ModalFooter display="flex" gap="8rem" p="0" mt="1.2rem"> | ||
<Button | ||
variant="none" | ||
fontSize="button" | ||
fontWeight="button" | ||
lineHeight="button" | ||
color="neutral.400" | ||
onClick={onClose} | ||
> | ||
취소 | ||
</Button> | ||
<Button | ||
variant="none" | ||
fontSize="button" | ||
fontWeight="button" | ||
lineHeight="button" | ||
color="primary.400" | ||
> | ||
확인 | ||
</Button> | ||
</ModalFooter> | ||
</ModalContent> | ||
</Modal> | ||
); | ||
} | ||
|
||
export default LeaveTripModal; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,6 @@ | ||
@use "@/sass" as *; | ||
|
||
header { | ||
.titleHeader { | ||
background-color: $neutral0; | ||
width: 100%; | ||
max-width: 45rem; | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
export interface ModalProps { | ||
isOpen: boolean; | ||
onOpen: () => void; | ||
onClose: () => void; | ||
} | ||
|
||
export type LeaveTripModalProps = Omit<ModalProps, "onOpen">; |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
헉 저도 지금 이 모달 만들고 있었는데 혹시 모달뜨면서 바텀슬라이드 내려가는거 해보셨나요??ㅜ
모달이나 바텀슬라이드나 같은 onClose를 쓰니까 꼬이는 것 같더라구요,,,, 우선 지금 이것저것 해보는데 시간을 많이 빼앗겨서... 서현님은 어떻게 하시나 궁금했습니다😥
(수정)
방금 해결했습니다ㅎㅎ..!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
은영님 PR 확인했습니다!! 참고할게요 👍🏻