Bugfix: prevent Loki from crashing when inventory contains items not (yet) supported #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will at least prevent Loki from crashing but maybe there are better ways of solving this. Another thought: I'd like to insert the actual internal game id (ie name) of the item in the inventory slot, instead of the fallback value 'item_name'. That way you can see what the name is that is missing, to be added in the SharedItemData DB. WPF is not my expertise so I don't know how to make a fallback that use the name of an item. Well, you could replace "item_data" with the item.name in code but that seems backwards...
jensbrak
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will at least prevent Loki from crashing but maybe there are better ways of solving this. This would fix the error reported in #30 (as in prevent Loki from crashing when unsupported items are in inventory. I have separate PR to add those missing items)
Another thought: I'd like to insert the actual internal game id (ie name) of the item in the inventory slot, instead of the fallback value 'item_name'. That way you can see what the name is that is missing, to be added in the SharedItemData DB. WPF is not my expertise so I don't know how to make a fallback that use the name of an item. Well, you could replace "item_data" with the item.name in code but that seems backwards...