Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Way conflicts are not resolved on upload #827

Open
GITMichaelK opened this issue Jan 19, 2025 · 6 comments
Open

Way conflicts are not resolved on upload #827

GITMichaelK opened this issue Jan 19, 2025 · 6 comments
Labels
API Related to data processing and OSM API bug Something isn't working
Milestone

Comments

@GITMichaelK
Copy link

Comparing my ChangeSets and MapChanges using HDYC (How Did You Contribute (Pascal Neis)), I found whenever using EveryDoor, the difference from day to day for ChangeSets is higher than the number of MapChanges. Pascal provided a database extract which shows, that EveryDoor provides a lot of empty changesets, please ref. the attached spreadsheet HDYC EveryDoor.xlsx:

  • Columns D and E showing the ChangeSets without any change,
  • their number is displayed in cell F2: 95 occurences.
  • Cells H1 : J2 show my results for MapChanges and ChangeSets on 13 and 14.01.2025 respectively,
  • the differences in row 4: 92 occurences.

Could someone explain the reason for the empty Changesets. Is there a way to avoid this?

@deevroman
Copy link
Contributor

  1. Empty changesets may be sent due to a poor connection.
  2. Go to settings and check that there are no error messages in the list of edits to be sent. If there is, then it is this bug: Creation of duplicate nodes #605 Remove edits with errors

@GITMichaelK
Copy link
Author

Thank you @deevroman,
there is no reason for a poor connection as I use EveryDoor only with LAN or wLAN; this means it' ON or OFF.
In regard to the bug I did not understand the full story, this is what my device shows:

Image
and after clicking ArrowUP:

Image

@pascal: Could you please provide me my list of changes for the last 30 Minutes form now? Thanks!

@deevroman
Copy link
Contributor

deevroman commented Jan 19, 2025

my list of changes for the last 30 Minutes form now?

use OSMcha

In regard to the bug I did not understand the full story, this is what my device shows:

This means there was a conflict when sending edits. There is a bug in EveryDoor due to which the presence of such errors can lead to empty changesets and even duplicate nodes. There is a way to reproduce this bug, but there is no fix yet.

Therefore, now you can only delete these edits. (or export them to fix them in JOSM)

@Zverik
Copy link
Owner

Zverik commented Jan 19, 2025

Hmm. This should not have happened. I look at this code and I think I programmed it backwards: it doesn't actually update node list before uploading a new version of a way. Hopefully it would be an easy fix for the next version.

@Zverik Zverik changed the title EveryDoor produces ChangeSets without any MapChange? Way conflicts are not resolved on upload Jan 19, 2025
@Zverik Zverik added this to the 6.0 milestone Jan 19, 2025
@Zverik Zverik added bug Something isn't working API Related to data processing and OSM API labels Jan 19, 2025
@Zverik Zverik moved this to Todo in Every Door Jan 19, 2025
@GITMichaelK
Copy link
Author

Thank you @Zverik! My Question, what should I do now:

  1. Delete the changes by hitting the garbage can in my first screenshot above to avoid empty changesets?
  2. Keep it for testing with updated programming accepting lots of empty changesets meanwhile?

@Zverik
Copy link
Owner

Zverik commented Jan 22, 2025

You can remove individual changes by swiping left. I will test this myself, so you don't need to keep it. Most likely the new version won't be published until late February, so no use keeping those. Although you might want to e.g. export them as osmChange and do the uploading via JOSM, or at least look at tag modifications (tap → tag panel button in the upper right corner) and redo them in josm/id.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API Related to data processing and OSM API bug Something isn't working
Projects
Status: Todo
Development

No branches or pull requests

3 participants