refactor: combine react and core packages into one #448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
AndyTWF
force-pushed
the
combine-packages
branch
from
0f711d4 to
ed47a8d
Compare
AndyTWF
force-pushed
the
combine-packages
branch
from
ed47a8d to
c7728a0
Compare
AndyTWF
force-pushed
the
combine-packages
branch
2 times, most recently
from
0ff8063 to
4ef9c39
Compare
AndyTWF
force-pushed
the
combine-packages
branch
from
4ef9c39 to
181084d
Compare
AndyTWF
force-pushed
the
combine-packages
branch
from
c575c2a to
0364290
Compare
AndyTWF
force-pushed
the
combine-packages
branch
from
0364290 to
926a138
Compare
AndyTWF
force-pushed
the
combine-packages
branch
from
926a138 to
aff846e
Compare
AndyTWF
force-pushed
the
combine-packages
branch
from
aff846e to
8ea5f14
Compare
AndyTWF
force-pushed
the
combine-packages
branch
from
8ea5f14 to
9087405
Compare
AndyTWF
force-pushed
the
combine-packages
branch
from
9087405 to
a75d14e
Compare
vladvelici
approved these changes
Jan 16, 2025
This change combines the core and react packages into one - so that one import is required to use the full suite of functionality. It also updates the build: dist/core is the core libraries only, which are used for the CDN upload. dist/chat is the entire library - both react and chat.
Adds the node engine version to package.json, which ensures we enforce the correct engine version.
This change allows the SDK to be tested and run against node 18.
AndyTWF
force-pushed
the
combine-packages
branch
from
864b57d to
9b704b0
Compare
|
Do we need to update the package.json to show the new node engine? |
| @@ -63,8 +56,21 @@ | |||
| "url": "https://github.com/ably/ably-chat-js/issues" | |||
| }, | |||
| "homepage": "https://github.com/ably/ably-chat-js#readme", | |||
| "engines": { | |||
| "node": ">=18.0.0" | |||
There was a problem hiding this comment.
This need to be updated?
There was a problem hiding this comment.
I just added this one as we didn't have it before - this should be ok as we are supporting Node 18+
splindsay-92
approved these changes
Jan 17, 2025
|
Forcing this merge as new checks aren't in main yet |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
CHADR-083
Docs PR: ably/docs#2385
Description
This change combines the core and react packages into one - so that one import is required to use the full suite of functionality.
Before users would do:
Now it is:
The build is updated as follows:
Also included are:
Checklist
Testing Instructions (Optional)
Please give the demo app a good test run to ensure that everything works as before.