temporary fix for problem debugged with jesscall #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
|
@jeffersoncasimir is this already fixed (should be closed) or could be included in the current/next EEG2BIDS / EDF2BIDS? |
|
To be tested in August |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief summary of changes
This PR is a temporary solution for the problem debugged with @jesscall. The code for this portion needs to be changed for potential edge cases of the events.tsv file that the user supplies. Example: column headers could not be in the assumed correct order and optional columns could exist that we're currently not handling.
The edge cases that will need to be solved and brought up in that EEG meeting are the following..
The order of the user supplied events.tsv “columns” could be different/mixed.
The optional values could be supplied by the user and code logic needs to account for them.
The BIDS generation can potentially make it’s own events.tsv file and that can be different than the user’s supplied events.tsv file. So the logic has to be able to handle refining the columns order and conflicts like lack of columns or extra columns.
Link(s) to related issue(s)
events.tsvfile is empty #79