Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADD: SearchAlgo Optuna - general ray search space #26

Closed
wants to merge 7 commits into from

Conversation

adamovanja
Copy link
Owner

@adamovanja adamovanja commented Aug 14, 2024

this PR:

  • adds optuna as search algorithm to be used
  • adjusts launching script on slurm with one node and multiple nodes
  • improves readme documentation

Copy link

codecov bot commented Aug 14, 2024

Codecov Report

Attention: Patch coverage is 20.00000% with 8 lines in your changes missing coverage. Please review.

Project coverage is 48.16%. Comparing base (7c6061e) to head (49c507f).

Files Patch % Lines
q2_ritme/tune_models.py 0.00% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #26      +/-   ##
==========================================
- Coverage   48.39%   48.16%   -0.24%     
==========================================
  Files          17       17              
  Lines        1029     1034       +5     
  Branches      156      156              
==========================================
  Hits          498      498              
- Misses        520      525       +5     
  Partials       11       11              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adamovanja
Copy link
Owner Author

closing since this PR does not include Optuna with own search space which does not allow conditional search spaces - this way included in PR #27.

keeping this for reference in case at some point a more general search space is needed

@adamovanja adamovanja closed this Aug 16, 2024
@adamovanja adamovanja changed the title ADD: SearchAlgo Optuna ADD: SearchAlgo Optuna - general ray search space Aug 16, 2024
@adamovanja adamovanja deleted the add_optuna_only branch August 16, 2024 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant