Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADD: SearchAlgo Optuna w own search space #27

Merged
merged 10 commits into from
Aug 16, 2024
Merged

Conversation

adamovanja
Copy link
Owner

@adamovanja adamovanja commented Aug 15, 2024

this PR:

  • adds optuna as search algorithm with own conditional search space [1]
  • adjusts launching script on slurm with one node and multiple nodes
  • improves readme documentation

[1]: difference to closed PR #26 is that here Optuna contains own search space. PR #26 contains search space that could be used with many other search algorithms in ray tune.

Copy link

codecov bot commented Aug 15, 2024

Codecov Report

Attention: Patch coverage is 83.51648% with 15 lines in your changes missing coverage. Please review.

Project coverage is 49.24%. Comparing base (7c6061e) to head (509fc1a).
Report is 1 commits behind head on main.

Files Patch % Lines
q2_ritme/tune_models.py 0.00% 11 Missing ⚠️
q2_ritme/model_space/static_searchspace.py 93.93% 1 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #27      +/-   ##
==========================================
+ Coverage   48.39%   49.24%   +0.85%     
==========================================
  Files          17       17              
  Lines        1029     1062      +33     
  Branches      156      160       +4     
==========================================
+ Hits          498      523      +25     
- Misses        520      527       +7     
- Partials       11       12       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adamovanja adamovanja merged commit 5644411 into main Aug 16, 2024
4 checks passed
@adamovanja adamovanja deleted the add_optuna_w_own_ss branch August 16, 2024 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant