fix(argoconfig): Remove empty syncPolicy from application template #1172
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes the empty syncPolicy from the application template. This change is needed because when you don't specify a syncPolicy in one of the helm-charts which use argoconfig, it will put just the empty syncPolicy in it. It seems like argoCD removes the empty value, which can be seen here:
This leads to a diff between the desired and live manifest.
After this change the helm-charts which depend on this also have to update their dependency to fix the issue.
Issues
Checklist
artifacthub.io/changes
annotation inChart.yaml
, check the example in the documentation.pre-commit run
docs/