fix: display error messages during installation #1909
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
If something goes wrong during packages installation, Agama web UI does not show any message. We
found out that there are some problems:
up).
QuestionsChanged
event if it is reconnecting the WebSocket at that point.Solution
To overcome those problems, we have introduced the following changes:
questions
query when the WebSocket is reconnected to make sure we do not miss anymessage.
Note
We could play with the
refetchOnReconnect
setting at global level. But let's be conservative atthis point.
Additional changes
agama-web-server
:web UI
:Testing
Screenshots