-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial moves to OpenAPI v3 #758
Conversation
|
Looks good! And we should implement the |
I am not up to speed on the automation. I am all in favor of keeping the specs in sync but not much I can contribute as reviewer. I will leave it in your hands to approve this, am removing myself as reviewer. 8-) |
Do we 1) remove the test data file from the lang directories or 2) leave them there? Probably 2) so that the lang directories are "complete" without additional steps. Similar to schema files, so should add consistency checks to verify the test data files match. |
the problem we will have with generating the v2 spec from v3 is that the output will not be pretty, will lose comments, etc., unless we write a sophisticated translation program, which probably isn't worth the effort. That implies we should stick with maintaining both files and the consistency check, until we are ready to completely deprecate v2. |
Mostly so I can create a pull request...
I created conflicts when merging in master incorrectly, so starting over with #767 |
Start building the base so we only need to edit the OpenAPI v3 spec, and the v2 spec can be generated from v3. Also clean up the test suites so there is one common set of test data files used by all languages.