Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix](regression)Fix unstable compaction related cases #46920

Merged
merged 3 commits into from
Jan 15, 2025
Merged

[fix](regression)Fix unstable compaction related cases #46920

merged 3 commits into from
Jan 15, 2025

Conversation

qidaye
Copy link
Contributor

@qidaye qidaye commented Jan 13, 2025 •
edited
Loading

What problem does this PR solve?

Related PR: #45761

Problem Summary:

  1. Added wait_for_build_index_on_partition_finish calls to ensure indexes are built before triggering compaction.

  2. When we do index compaction fault injection test, compaction status e-6010 is expected sometimes. Added an ignored_errors parameter to the trigger_and_wait_compaction method, allowing specific errors to be ignored during compaction.

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@qidaye
Copy link
Contributor Author

qidaye commented Jan 13, 2025

run buildall

zzzxl1993
zzzxl1993 approved these changes Jan 14, 2025
View reviewed changes
Copy link
Contributor

@zzzxl1993 zzzxl1993 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions GitHub Actions
Copy link
Contributor

PR approved by anyone and no changes requested.

airborne12
airborne12 previously approved these changes Jan 14, 2025
View reviewed changes
Copy link
Member

@airborne12 airborne12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jan 14, 2025
@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@qidaye qidaye marked this pull request as draft January 14, 2025 07:38
@qidaye qidaye marked this pull request as ready for review January 14, 2025 08:01
@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Jan 14, 2025
@qidaye
Copy link
Contributor Author

qidaye commented Jan 14, 2025

run buildall

py023
py023 approved these changes Jan 14, 2025
View reviewed changes
Copy link
Contributor

@py023 py023 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest LGTM

regression-test/suites/fault_injection_p0/test_skip_index_compaction_fault_injection.groovy Outdated Show resolved Hide resolved
@qidaye
Copy link
Contributor Author

qidaye commented Jan 14, 2025

run buildall

py023
py023 approved these changes Jan 14, 2025
View reviewed changes
Copy link
Contributor

@py023 py023 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

shuke987
shuke987 approved these changes Jan 15, 2025
View reviewed changes
Copy link
Collaborator

@shuke987 shuke987 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

airborne12
airborne12 approved these changes Jan 15, 2025
View reviewed changes
Copy link
Member

@airborne12 airborne12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jan 15, 2025
@qidaye qidaye merged commit c76f309 into apache:master Jan 15, 2025
31 checks passed
@qidaye qidaye deleted the fix_case_trigger_with_retry branch January 15, 2025 02:18
qidaye added a commit to qidaye/incubator-doris that referenced this pull request Jan 15, 2025
@qidaye
[fix](regression)Fix unstable compaction related cases (apache#46920)
00e4053 
Related PR: apache#45761

Problem Summary:

1. Added `wait_for_build_index_on_partition_finish` calls to ensure
indexes are built before triggering compaction.

2. When we do index compaction fault injection test, compaction status
`e-6010` is expected sometimes. Added an `ignored_errors` parameter to
the `trigger_and_wait_compaction` method, allowing specific errors to be
ignored during compaction.
@qidaye qidaye mentioned this pull request Jan 15, 2025
Merged
qidaye added a commit to qidaye/incubator-doris that referenced this pull request Jan 15, 2025
@qidaye
[fix](regression)Fix unstable compaction related cases (apache#46920)
fd34e05 
Related PR: apache#45761

Problem Summary:

1. Added `wait_for_build_index_on_partition_finish` calls to ensure
indexes are built before triggering compaction.

2. When we do index compaction fault injection test, compaction status
`e-6010` is expected sometimes. Added an `ignored_errors` parameter to
the `trigger_and_wait_compaction` method, allowing specific errors to be
ignored during compaction.
qidaye added a commit to qidaye/incubator-doris that referenced this pull request Jan 15, 2025
@qidaye
[fix](regression)Fix unstable compaction related cases (apache#46920)
e6cbe73 
Related PR: apache#45761

Problem Summary:

1. Added `wait_for_build_index_on_partition_finish` calls to ensure
indexes are built before triggering compaction.

2. When we do index compaction fault injection test, compaction status
`e-6010` is expected sometimes. Added an `ignored_errors` parameter to
the `trigger_and_wait_compaction` method, allowing specific errors to be
ignored during compaction.
@qidaye qidaye mentioned this pull request Jan 15, 2025
Merged
yiguolei pushed a commit that referenced this pull request Jan 15, 2025
@qidaye
[fix](regression)Fix unstable compaction related cases (#46920) (#47003)
385589c 
bp #46920
qidaye added a commit that referenced this pull request Jan 15, 2025
@qidaye
[fix](regression)Fix unstable compaction related cases (#46920) (#47002)
ed78d99 
bp #46920
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@airborne12 airborne12 airborne12 approved these changes

@zzzxl1993 zzzxl1993 zzzxl1993 approved these changes

@shuke987 shuke987 shuke987 approved these changes

@py023 py023 py023 approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. dev/2.1.8-merged dev/3.0.4-merged reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@qidaye @hello-stephen @airborne12 @zzzxl1993 @shuke987 @py023 @yiguolei