HDDS-11758. Require successful quick checks for repro #7461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dombizita
approved these changes
Feb 10, 2025
|
Thanks @dombizita for the review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Background:
basicchecks run in parallel withbuilddependencyandlicensechecks wait forbuild, but are fairly quickreprocheck repeats build and checks for differencesWait for
basic,dependencyandlicenseto succeed before startingreprocheck. This way if trivial errors are found by any of the prerequisites (e.g. checkstyle violation), we save time by avoiding the lengthy rebuild process.To simplify things,
needs-dependency-checkflag is removed,dependencyandlicenseare triggered after successful build in all runs.https://issues.apache.org/jira/browse/HDDS-11758
How was this patch tested?
Updated bats tests.
CI:
https://github.com/adoroszlai/ozone/actions/runs/11934931757