Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HDDS-11758. Require successful quick checks for repro #7461

Merged
merged 3 commits into from
Feb 10, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,6 @@ jobs:
needs-build: ${{ steps.selective-checks.outputs.needs-build }}
needs-compile: ${{ steps.selective-checks.outputs.needs-compile }}
needs-compose-tests: ${{ steps.selective-checks.outputs.needs-compose-tests }}
needs-dependency-check: ${{ steps.selective-checks.outputs.needs-dependency-check }}
needs-integration-tests: ${{ steps.selective-checks.outputs.needs-integration-tests }}
needs-kubernetes-tests: ${{ steps.selective-checks.outputs.needs-kubernetes-tests }}
sha: ${{ steps.get-sha.outputs.sha }}
Expand Down Expand Up @@ -356,7 +355,6 @@ jobs:
- build
runs-on: ubuntu-20.04
timeout-minutes: 5
if: needs.build-info.outputs.needs-dependency-check == 'true'
steps:
- name: Checkout project
uses: actions/checkout@v4
Expand Down Expand Up @@ -396,7 +394,6 @@ jobs:
- build
runs-on: ubuntu-20.04
timeout-minutes: 15
if: needs.build-info.outputs.needs-dependency-check == 'true'
steps:
- name: Checkout project
uses: actions/checkout@v4
Expand Down Expand Up @@ -440,6 +437,9 @@ jobs:
needs:
- build-info
- build
- basic
- dependency
- license
runs-on: ubuntu-20.04
timeout-minutes: 30
steps:
Expand Down
36 changes: 1 addition & 35 deletions dev-support/ci/selective_ci_checks.bats
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,6 @@ load bats-assert/load.bash
assert_output -p needs-build=false
assert_output -p needs-compile=false
assert_output -p needs-compose-tests=false
assert_output -p needs-dependency-check=false
assert_output -p needs-integration-tests=false
assert_output -p needs-kubernetes-tests=false
}
Expand All @@ -52,7 +51,6 @@ load bats-assert/load.bash
assert_output -p needs-build=true
assert_output -p needs-compile=false
assert_output -p needs-compose-tests=true
assert_output -p needs-dependency-check=true
assert_output -p needs-integration-tests=false
assert_output -p needs-kubernetes-tests=false
}
Expand All @@ -64,7 +62,6 @@ load bats-assert/load.bash
assert_output -p needs-build=false
assert_output -p needs-compile=false
assert_output -p needs-compose-tests=false
assert_output -p needs-dependency-check=false
assert_output -p needs-integration-tests=false
assert_output -p needs-kubernetes-tests=false
}
Expand All @@ -76,7 +73,6 @@ load bats-assert/load.bash
assert_output -p needs-build=true
assert_output -p needs-compile=false
assert_output -p needs-compose-tests=true
assert_output -p needs-dependency-check=true
assert_output -p needs-integration-tests=false
assert_output -p needs-kubernetes-tests=true
}
Expand All @@ -88,7 +84,6 @@ load bats-assert/load.bash
assert_output -p needs-build=true
assert_output -p needs-compile=true
assert_output -p needs-compose-tests=true
assert_output -p needs-dependency-check=true
assert_output -p needs-integration-tests=false
assert_output -p needs-kubernetes-tests=true
}
Expand All @@ -100,7 +95,6 @@ load bats-assert/load.bash
assert_output -p needs-build=true
assert_output -p needs-compile=false
assert_output -p needs-compose-tests=true
assert_output -p needs-dependency-check=true
assert_output -p needs-integration-tests=false
assert_output -p needs-kubernetes-tests=true
}
Expand All @@ -112,7 +106,6 @@ load bats-assert/load.bash
assert_output -p needs-build=true
assert_output -p needs-compile=true
assert_output -p needs-compose-tests=false
assert_output -p needs-dependency-check=true
assert_output -p needs-integration-tests=true
assert_output -p needs-kubernetes-tests=false
}
Expand All @@ -124,7 +117,6 @@ load bats-assert/load.bash
assert_output -p needs-build=false
assert_output -p needs-compile=false
assert_output -p needs-compose-tests=false
assert_output -p needs-dependency-check=false
assert_output -p needs-integration-tests=true
assert_output -p needs-kubernetes-tests=false
}
Expand All @@ -136,7 +128,6 @@ load bats-assert/load.bash
assert_output -p needs-build=true
assert_output -p needs-compile=true
assert_output -p needs-compose-tests=false
assert_output -p needs-dependency-check=true
assert_output -p needs-integration-tests=true
assert_output -p needs-kubernetes-tests=false
}
Expand All @@ -148,7 +139,6 @@ load bats-assert/load.bash
assert_output -p needs-build=true
assert_output -p needs-compile=true
assert_output -p needs-compose-tests=false
assert_output -p needs-dependency-check=true
assert_output -p needs-integration-tests=true
assert_output -p needs-kubernetes-tests=false
}
Expand All @@ -160,7 +150,6 @@ load bats-assert/load.bash
assert_output -p needs-build=true
assert_output -p needs-compile=true
assert_output -p needs-compose-tests=false
assert_output -p needs-dependency-check=true
assert_output -p needs-integration-tests=true
assert_output -p needs-kubernetes-tests=false
}
Expand All @@ -172,7 +161,6 @@ load bats-assert/load.bash
assert_output -p needs-build=true
assert_output -p needs-compile=true
assert_output -p needs-compose-tests=false
assert_output -p needs-dependency-check=true
assert_output -p needs-integration-tests=true
assert_output -p needs-kubernetes-tests=false
}
Expand All @@ -184,7 +172,6 @@ load bats-assert/load.bash
assert_output -p needs-build=true
assert_output -p needs-compile=true
assert_output -p needs-compose-tests=false
assert_output -p needs-dependency-check=true
assert_output -p needs-integration-tests=false
assert_output -p needs-kubernetes-tests=false
}
Expand All @@ -196,7 +183,6 @@ load bats-assert/load.bash
assert_output -p needs-build=true
assert_output -p needs-compile=true
assert_output -p needs-compose-tests=false
assert_output -p needs-dependency-check=true
assert_output -p needs-integration-tests=false
assert_output -p needs-kubernetes-tests=false
}
Expand All @@ -208,7 +194,6 @@ load bats-assert/load.bash
assert_output -p needs-build=true
assert_output -p needs-compile=false
assert_output -p needs-compose-tests=false
assert_output -p needs-dependency-check=true
assert_output -p needs-integration-tests=false
assert_output -p needs-kubernetes-tests=true
}
Expand All @@ -220,7 +205,6 @@ load bats-assert/load.bash
assert_output -p needs-build=false
assert_output -p needs-compile=false
assert_output -p needs-compose-tests=false
assert_output -p needs-dependency-check=false
assert_output -p needs-integration-tests=false
assert_output -p needs-kubernetes-tests=false
}
Expand All @@ -232,7 +216,6 @@ load bats-assert/load.bash
assert_output -p needs-build=true
assert_output -p needs-compile=true
assert_output -p needs-compose-tests=true
assert_output -p needs-dependency-check=true
assert_output -p needs-integration-tests=true
assert_output -p needs-kubernetes-tests=true
}
Expand All @@ -244,7 +227,6 @@ load bats-assert/load.bash
assert_output -p needs-build=true
assert_output -p needs-compile=true
assert_output -p needs-compose-tests=true
assert_output -p needs-dependency-check=true
assert_output -p needs-integration-tests=true
assert_output -p needs-kubernetes-tests=true
}
Expand All @@ -256,7 +238,6 @@ load bats-assert/load.bash
assert_output -p needs-build=true
assert_output -p needs-compile=true
assert_output -p needs-compose-tests=true
assert_output -p needs-dependency-check=true
assert_output -p needs-integration-tests=true
assert_output -p needs-kubernetes-tests=true
}
Expand All @@ -268,7 +249,6 @@ load bats-assert/load.bash
assert_output -p needs-build=true
assert_output -p needs-compile=true
assert_output -p needs-compose-tests=true
assert_output -p needs-dependency-check=true
assert_output -p needs-integration-tests=true
assert_output -p needs-kubernetes-tests=true
}
Expand All @@ -280,7 +260,6 @@ load bats-assert/load.bash
assert_output -p needs-build=true
assert_output -p needs-compile=true
assert_output -p needs-compose-tests=true
assert_output -p needs-dependency-check=true
assert_output -p needs-integration-tests=true
assert_output -p needs-kubernetes-tests=true
}
Expand All @@ -292,7 +271,6 @@ load bats-assert/load.bash
assert_output -p needs-build=true
assert_output -p needs-compile=true
assert_output -p needs-compose-tests=true
assert_output -p needs-dependency-check=true
assert_output -p needs-integration-tests=true
assert_output -p needs-kubernetes-tests=true
}
Expand All @@ -304,7 +282,6 @@ load bats-assert/load.bash
assert_output -p needs-build=true
assert_output -p needs-compile=true
assert_output -p needs-compose-tests=true
assert_output -p needs-dependency-check=true
assert_output -p needs-integration-tests=true
assert_output -p needs-kubernetes-tests=true
}
Expand All @@ -317,7 +294,6 @@ load bats-assert/load.bash
assert_output -p needs-build=false
assert_output -p needs-compile=false
assert_output -p needs-compose-tests=false
assert_output -p needs-dependency-check=false
assert_output -p needs-integration-tests=false
assert_output -p needs-kubernetes-tests=false
}
Expand All @@ -329,7 +305,6 @@ load bats-assert/load.bash
assert_output -p needs-build=true
assert_output -p needs-compile=true
assert_output -p needs-compose-tests=true
assert_output -p needs-dependency-check=true
assert_output -p needs-integration-tests=true
assert_output -p needs-kubernetes-tests=true
}
Expand All @@ -341,7 +316,6 @@ load bats-assert/load.bash
assert_output -p needs-build=false
assert_output -p needs-compile=false
assert_output -p needs-compose-tests=false
assert_output -p needs-dependency-check=false
assert_output -p needs-integration-tests=false
assert_output -p needs-kubernetes-tests=false
}
Expand All @@ -353,7 +327,6 @@ load bats-assert/load.bash
assert_output -p needs-build=false
assert_output -p needs-compile=false
assert_output -p needs-compose-tests=false
assert_output -p needs-dependency-check=false
assert_output -p needs-integration-tests=false
assert_output -p needs-kubernetes-tests=false
}
Expand All @@ -365,7 +338,6 @@ load bats-assert/load.bash
assert_output -p needs-build=false
assert_output -p needs-compile=false
assert_output -p needs-compose-tests=false
assert_output -p needs-dependency-check=false
assert_output -p needs-integration-tests=false
assert_output -p needs-kubernetes-tests=false
}
Expand All @@ -377,7 +349,6 @@ load bats-assert/load.bash
assert_output -p needs-build=false
assert_output -p needs-compile=false
assert_output -p needs-compose-tests=false
assert_output -p needs-dependency-check=false
assert_output -p needs-integration-tests=false
assert_output -p needs-kubernetes-tests=false
}
Expand All @@ -389,7 +360,6 @@ load bats-assert/load.bash
assert_output -p needs-build=false
assert_output -p needs-compile=false
assert_output -p needs-compose-tests=false
assert_output -p needs-dependency-check=false
assert_output -p needs-integration-tests=false
assert_output -p needs-kubernetes-tests=false
}
Expand All @@ -401,7 +371,6 @@ load bats-assert/load.bash
assert_output -p needs-build=true
assert_output -p needs-compile=false
assert_output -p needs-compose-tests=false
assert_output -p needs-dependency-check=false
assert_output -p needs-integration-tests=false
assert_output -p needs-kubernetes-tests=false
}
Expand All @@ -413,7 +382,6 @@ load bats-assert/load.bash
assert_output -p needs-build=false
assert_output -p needs-compile=false
assert_output -p needs-compose-tests=false
assert_output -p needs-dependency-check=false
assert_output -p needs-integration-tests=false
assert_output -p needs-kubernetes-tests=false
}
Expand All @@ -422,10 +390,9 @@ load bats-assert/load.bash
run dev-support/ci/selective_ci_checks.sh 47a5671cc5

assert_output -p 'basic-checks=["rat","bats"]'
assert_output -p needs-build=false
assert_output -p needs-build=true
assert_output -p needs-compile=false
assert_output -p needs-compose-tests=false
assert_output -p needs-dependency-check=true
assert_output -p needs-integration-tests=false
assert_output -p needs-kubernetes-tests=false
}
Expand All @@ -437,7 +404,6 @@ load bats-assert/load.bash
assert_output -p needs-build=false
assert_output -p needs-compile=false
assert_output -p needs-compose-tests=false
assert_output -p needs-dependency-check=false
assert_output -p needs-integration-tests=true
assert_output -p needs-kubernetes-tests=false
}
Loading